-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CNS-340 - add ability to publish to specific subject hierarchies #112
Conversation
…he configured topic of the push server via a new functional option
// | ||
// see: https://docs.nats.io/nats-concepts/subjects#wildcards for more details. | ||
// | ||
// TODO: in the future, support to subscribing to specific subjects and/or wildcards may be added. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👀 @primalmotion 😉
Codecov Report
@@ Coverage Diff @@
## master #112 +/- ##
==========================================
+ Coverage 90.51% 90.54% +0.02%
==========================================
Files 45 45
Lines 3185 3195 +10
==========================================
+ Hits 2883 2893 +10
+ Misses 234 233 -1
- Partials 68 69 +1
Continue to review full report at Codecov.
|
/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0
|
/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0
|
/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0
|
/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0
|
1 similar comment
/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0
|
Context
This PR adds an optional ability to publish to specific subject hierarchies of the configured topic of the push server via a new functional option
OptPushServerEnableSubjectHierarchies
.The goal is to provide subscribers the ability to receive only events they care about instead of having them be required to add logic to ignore events they are not interested in.
For example:
If the push server topic has been set to
global-events
and the server is about to push a "create" event w/ an identity value of "apples", enabling this option, would cause the push server to target a new publication to the subjectglobal-events.apples.create
, INSTEAD OFglobal-events
.See https://docs.nats.io/nats-concepts/subjects for more details.
Will be used to solve