-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement] Improve support for circular $ref pointers #154
Conversation
Size Change: +196 kB (+6%) 🔍 Total Size: 3.58 MB
ℹ️ View Unchanged
|
Visit the preview URL for this PR (updated for commit 70b31c4): https://docusaurus-openapi-36b86--pr154-uxbte6ya.web.app (expires Fri, 12 Aug 2022 15:12:27 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
6efb576
to
197421d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Circular $ref pointers have been resolved. Thanks @sserrata! 🚀
Will open a new PR to address remaining gaps in schema parsing in |
Description
This PR introduces a new
loadAndResolve()
helper for resolving circular$ref
pointers while ensuring downstream compatibility with supporting libraries can require ability to serialize the OpenAPI object.Additionally, this PR attempts to extend support for
oneOf
,anyOf
andallOf
.Motivation and Context
Circular
$ref
pointer support is required for a number of our product APIs and could be leveraged by others in the OpenAPI community.How Has This Been Tested?
Tested with Petstore and SearchManager API specs.
Additional changes
Previously, the
createAnyOneOf
module was rendering a details component. This PR usescreateRows()
to eliminate the unnecessary "Schema" dropdown.TODO