Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add new community argument for bgp_policy_rule #543

Draft
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

adambaumeister
Copy link
Collaborator

Reflecting the changes made in this PR to pan-os-python: https://github.com/PaloAltoNetworks/pan-os-python/pull/535/files#diff-43b846942e01ef0d6442ff29e000fe176057b3a41979d9eb27fd7d549e6d6527

Adds the "action_community_modifier" argument to the panos_bgp_policy_rule.

@adambaumeister adambaumeister marked this pull request as ready for review February 15, 2024 02:05
@adambaumeister
Copy link
Collaborator Author

actually I just realized. This can't be released until pan-os-python releases or the module won't work :/

@adambaumeister adambaumeister marked this pull request as draft February 15, 2024 06:19
@alperenkose
Copy link
Collaborator

@adambaumeister I created a separate PR ( #547 ) for the EDA linting fix here on the following link not to wait for the pan-os-python release.

Copy link
Collaborator

@alperenkose alperenkose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adambaumeister I think we can merge this now as I see there is a new release on pan-os-python ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants