chore: standard semantic release rules #126
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FoSix
requested review from
alperenkose,
adambaumeister and
horiagunica
as code owners
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified FilesNo covered modified files...
|
|
A Preview PR in PanDev repo has been created. You can view it here. |
michalbil
approved these changes
Nov 29, 2023
alperenkose
approved these changes
Nov 30, 2023
|
Shall we wait for the #128 merge which would be a breaking change before merging this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove the custom release version calculation rules: feat -> patch, braking -> minor, feat(MAJOR) -> major.
Motivation and Context
There were no braking changes recently, we can assume the code is major enough not to produce tons of major versions.
We also need to align the rules for calculating releases with
pan-os-ansibleproject.How Has This Been Tested?
Screenshots (if appropriate)
Types of changes
Checklist