-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: multi-level snapshot comparison and config parser refactor #128
refactor!: multi-level snapshot comparison and config parser refactor #128
Conversation
Co-authored-by: Łukasz Pawlęga <42772730+FoSix@users.noreply.github.com>
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
A Preview PR in PanDev repo has been created. You can view it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
🎉 This PR is included in version 1.0.0 🎉 The release is available on PyPI and GitHub release
|
Description
This PR enhances snapshot comparison by allowing properties to be filtered on different levels of the snapshots.
missing/added comparison fields are also filtered according to the properties set.
It includes refactoring of ConfigParser class providing usable static methods for SnapshotComparison.
Motivation and Context
It fixes the issue #108 and complements the draft #109 PR.
In addition to the mentioned issue, considering the below snapshots (snapshot-1 and snapshot-2), it makes it possible to compare/exclude fields on different levels. See all possible examples below:
snapshot-1
snapshot-2
How Has This Been Tested?
Tested with example scripts.
Types of changes
Checklist