This repository has been archived by the owner on Feb 14, 2024. It is now read-only.
feat(modules/asg): support VPC association for Lambda #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ist of security groups and subnets in the VPC can be provided for Lambda function
sebastianczech
changed the title
… configure connection to AWS services via NAT GW
|
Since we have decided to remove |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current Lambda function in the
asgmodule doesn't support an association with a VPC network.Changes delivered in PR allow user to specify a subnets and security groups to associate the Lambda function with (if required). If both
lambda_subnet_idsandlambda_security_group_idsare empty thenvpc_configis considered to be empty or unset.Motivation and Context
It fixes an issue #288
How Has This Been Tested?
It was tested with
asgexample, but it required more changes described in #288. Example for asg was extended too.Types of changes
Checklist