Skip to content
This repository has been archived by the owner on Feb 14, 2024. It is now read-only.

feat(modules/asg, examples/asg_gwlb): Fix issues in ASG module and add new example for GWLB with ASG #290

Merged
merged 7 commits into from
Mar 17, 2023
Merged

feat(modules/asg, examples/asg_gwlb): Fix issues in ASG module and add new example for GWLB with ASG #290

merged 7 commits into from
Mar 17, 2023

Conversation

sebastianczech
Copy link
Contributor

@sebastianczech sebastianczech commented Mar 6, 2023 •
edited
Loading

Description

PR delivers:

  • improvements in ASG module:
    • add Python function in Lambda to disable source/destination check for dataplane interface
    • add EBS encryption for instance created by launch template
    • add target group for GWLB in ASG to register/deregister instances
    • add autoscaling plan resource
  • new example for ASG with GWLB

NOTE: Lambda doesn't contain delicense part.

Motivation and Context

#250

How Has This Been Tested?

Changes in asg module were tested while preparing new example asg_gwlb.

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

@sebastianczech
Fix issues in Lambda for ASG (e.g. disable source/destination check f…
0f8ada2 
…or dataplane), add EBS encryption for instance created by launch template, add target group for GWLB in ASG to register/deregister instances, add autoscalling plan resource
@sebastianczech
New exampel for autoscaling group with GWLB
c335ce9
@sebastianczech
Update README
0ea3c1c
@sebastianczech sebastianczech changed the title feat(modules/asg, examples/asg_gwlb): Fix issues in ASG and add new example for GWLB with ASG feat(modules/asg, examples/asg_gwlb): Fix issues in ASG module and add new example for GWLB with ASG Mar 6, 2023
@sebastianczech sebastianczech mentioned this pull request Mar 6, 2023
Closed
@sebastianczech sebastianczech marked this pull request as ready for review March 6, 2023 15:44
@sebastianczech sebastianczech requested a review from a team as a code owner March 6, 2023 15:44
migara
migara approved these changes Mar 15, 2023
View reviewed changes
Copy link
Member

@migara migara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 👍🏽

@migara migara mentioned this pull request Mar 15, 2023
Closed
4 tasks
@migara
Copy link
Member

migara commented Mar 15, 2023

Let's rename this example name to asg-combined-model

@migara migara mentioned this pull request Mar 15, 2023
Closed
4 tasks
lstadnik
lstadnik approved these changes Mar 17, 2023
View reviewed changes
Copy link
Contributor

@lstadnik lstadnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sebastianczech sebastianczech merged commit 5cc1ea1 into main Mar 17, 2023
@sebastianczech sebastianczech deleted the asg-gwlb-250 branch March 17, 2023 07:32
@github-actions
Copy link
Contributor

🎉 This PR is included in version 0.4.2 🎉

The release is available on Terraform Registry and GitHub release

Posted by semantic-release bot

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@migara migara migara approved these changes

@lstadnik lstadnik lstadnik approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sebastianczech @migara @lstadnik