DSSM 24.08.0: Feature/203 json for mapr #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arunge
requested changes
Aug 5, 2024
| gsub(" ", "", input$`mapr-group`),"/", | ||
| gsub(" ", "", input$`mapr-variable`),"/", | ||
| gsub(" ", "", input$`mapr-measure`),"/", | ||
| i,".png") |
There was a problem hiding this comment.
".png"
Is MapR only able to read ".png" or could the type be set by the user via input$exportType as for the other series of plots?
In both cases, please consider to check (and if necessary to update) the choices for "exportType".
There was a problem hiding this comment.
png is indeed the only supported file type from the file types that can by selected by the user. The other supported file type in MapR is nc. Therefore, and also because the export zipm file is intended to be uploaded to mapR only and not to be used without the app or something, I thought it might be useful to ignore the file type that was selected. Are you fine with it or should I still add anything? Of course I could change file type to png if mapr is selected. However, I wanted to keep the complexity low. Another option would be to display a note or something. What do you think?
There was a problem hiding this comment.
Ok, I think than it is good to make a note for the user, e.g. "MapR only supports .png export. Ignoring 'Filetype' input."
There was a problem hiding this comment.
I have added the helptext
| figFilename <- figFileNames[[which(times == i)]] | ||
|
|
||
| # save desired file type | ||
| writeGraphics(exportType = "png", |
There was a problem hiding this comment.
exportType = "png"
see above
* inline function for file extension * fix typo * add comment * fix logic, remove package magrittr
arunge
approved these changes
Aug 8, 2024
arunge
changed the title
arunge
added a commit
that referenced
this pull request
Aug 16, 2024
* altitude operations (#191) * altitude operations * Fix * set default differently * make data points selectable in locateR * update news * Fix for older version * fixes * fix progress message * remove comments --------- Co-authored-by: Antonia Runge <antonia.runge@inwt-statistics.de> * Fix error with mask (#208) * add new tests * extract function centerPlotData * add tryCatch to plotting of map, add data preview, add logDebugs * remove deprecated parameter 'mainfolder', add data preview * update news.md * catch failing of maskDraw if no data * update news.md * fix issue when drawing only centroids, add test * add tryCatch to left plotting functions * Version 24.05.0: Feat/202 contour maps (#210) * option to use simple contour map, some formatting * update news.md * Feat/169 centering of coordinates (#215) * new functions and ui input * align values * center predictions * UI to center data coordinates before modelling * add logic to center data before modelling to different modelling tabs * add logic * remove comments * update news.md * update news.md * rename input to prevent confusion with parameter from batch mode * extract processing of coordinate data * extract and apply data augmentation * fix issue with wrong default zoom when switching the map center * add more docu * more docu * update test because of new logic * add a vignette to the package about the processing of coordinate data * update news.md * fix for data augmentation * Version 24.05.2: option to select a specific color for "fixed" point colour (#216) * option to select a specific color for "fixed" point colour * new button to apply point settings and the logic * update news.md * update tests after adding new input * fix news.md * MpiIsoApp 24.05.3: Bugfix missing lat/long (#219) * BUG!! * Bugfix * update news.md --------- Co-authored-by: Antonia Runge <antonia.runge@inwt-statistics.de> * MpiIsoApp 24.05.4: fix warning (#217) * fix warning * extract updatePenalty function * update news.md --------- Co-authored-by: Antonia Runge <antonia.runge@inwt-statistics.de> * MpiIsoApp 24.05.5: optionally download savedMaps (#222) * optionally download savedMaps * format new UI * MpiIsoApp 24.05.6: option to export all plots from savedMaps (#223) * option to export all plots from savedMaps * remove not required * picker input to select savedMaps for download * shift code * update news.md * fix issue with missing thumbnail plot * return empty list if missing * cleaner return * remove option to download savedMaps objects * add docu * add param to docu * MpiIsoApp 24.05.7: Feat/224 warning if creating prob map (#225) * fix issue with missing thumbnails, fix pch value * update news.md * set pch to NA * remove warning * replace deprecated package name * Feature/203 json for mapr (#234) * zipm export option * namespace * Feature/203 json for mapr review (#235) * inline function for file extension * fix typo * add comment * fix logic, remove package magrittr * add helpttext ignoring Filetype input --------- Co-authored-by: Antonia Runge <antonia.runge@inwt-statistics.de> * fix cluster ids (#239) * fix cluster ids * extract logic into function * fix name of df --------- Co-authored-by: Antonia Runge <antonia.runge@inwt-statistics.de> --------- Co-authored-by: Marcus Groß <marcus.gross@inwt-statistics.de> Co-authored-by: Lukas Fuchs <86153843+f-lukas@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DSSM 24.08.0
New Features