RegistrySet API #10699
Merged
RegistrySet API #10699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Machine-Maker
force-pushed
the
feature/RegistrySet
branch
3 times, most recently
from
dc70c95
to
d65f9b1
Compare
Machine-Maker
force-pushed
the
feature/RegistrySet
branch
3 times, most recently
from
d1f4416
to
5676bda
Compare
kennytv
approved these changes
Jun 9, 2024
Owen1212055
approved these changes
Jun 9, 2024
Machine-Maker
force-pushed
the
feature/RegistrySet
branch
from
877b8cf
to
d562bfd
Compare
lynxplay
force-pushed
the
feature/RegistrySet
branch
from
d562bfd
to
32dbd09
Compare
Machine-Maker
force-pushed
the
feature/RegistrySet
branch
4 times, most recently
from
4e06474
to
1274048
Compare
Machine-Maker
force-pushed
the
dev/registry-modification
branch
from
e3c7b19
to
5f55edc
Compare
Machine-Maker
force-pushed
the
feature/RegistrySet
branch
3 times, most recently
from
005847b
to
0278072
Compare
Machine-Maker
force-pushed
the
feature/RegistrySet
branch
from
0278072
to
d07bdbb
Compare
Machine-Maker
merged commit 76e4b36
into
dev/registry-modification
3 of 4 checks passed
Machine-Maker
added a commit
that referenced
this pull request
Jun 15, 2024
Machine-Maker
added a commit
that referenced
this pull request
Jun 15, 2024
Machine-Maker
added a commit
that referenced
this pull request
Jun 15, 2024
Machine-Maker
added a commit
that referenced
this pull request
Jun 15, 2024
Machine-Maker
added a commit
that referenced
this pull request
Jun 15, 2024
Machine-Maker
added a commit
that referenced
this pull request
Jun 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This API is supposed to introduce an API equivalent to nms' HolderSet and HolderSet$Named.
RegistrySetis the base interface with subtypes inRegistryKeySetandRegistryValueSet.RegistryKeySetis equivalent to aHolderSetfilled only with "reference" holders whereas aRegistryValueSetis filled with only "direct" holders. We can safely assume that aHolderSetwill only contain 1 type of holder at a time because all the codecs that encode HolderSets require that.