Fixes issues in the suppress dismount cancellation patch #10735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennytv
reviewed
May 16, 2024
patches/server/0271-force-entity-dismount-during-teleportation.patch
Outdated
Show resolved
Hide resolved
Machine-Maker
force-pushed
the
fix/dismount-suppress-cancels
branch
from
d46d99b
to
b5f4eee
Compare
electronicboy
approved these changes
May 17, 2024
Machine-Maker
force-pushed
the
fix/dismount-suppress-cancels
branch
from
b5f4eee
to
7dccb31
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
suppressCancellationfunctionality here isn't used almost anywhere, especially in teleportation despite the patch title. However it will be once the re-work of internal teleportation logic is done. This fixes an issue in that patch where the original OBFHELPER name selected for the overloads turned out to conflict with a mojang named method so the overrides where almost linked together in such a way to cause a StackOverflow. I don't think there was a possibility of one, but this removes all chance.