Fix Cancelling BlockPlaceEvent calling onRemove #10773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
electronicboy
approved these changes
May 24, 2024
lynxplay
force-pushed
the
fix-blockplaceevent-call-onremove
branch
from
7432eb7
to
b384e1e
Compare
Machine-Maker
approved these changes
May 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #10151
fixes #10292
The onRemove methods are often responsible for updating neighbouring blocks, which we don't want to update if BlockPlaceEvent is cancelled.
This doesn't only fix the example shown in the linked issue but also other issues regarding other redstone blocks like wires (there might be more just from looking at onRemove implementations on different redstone blocks, though i didn't test those).