Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cached, local-class-supporting task names #1399

Closed
wants to merge 0 commits into from
Closed

Cached, local-class-supporting task names #1399

wants to merge 0 commits into from

Conversation

Trigary
Copy link
Contributor

@Trigary Trigary commented Sep 2, 2018

Fixes issue #1177

MapMaker#weakKeys() makes the Map use identity comparison for the keys, while also enabling the automatical removal of dropped classes from the cache.

aikar
aikar approved these changes Sep 2, 2018
View reviewed changes
Copy link
Member

@aikar aikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you merge this into the timings patch please, otherwise looks good.
. If you have trouble just let me know and I can merge it

@Trigary Trigary closed this Sep 2, 2018
@Trigary
Copy link
Contributor Author

Trigary commented Sep 2, 2018

I have deleted the commit by mistake. I am going to successfully modify patch 009, it's just a matter of time and patience.

@Trigary Trigary mentioned this pull request Sep 3, 2018
Merged
@aikar aikar added the resolution: superseded A new PR has replaced this one label Sep 3, 2018
aikar pushed a commit that referenced this pull request Sep 3, 2018
@Trigary @aikar
Cached, local-class-supporting task names (#1409)
2d45ec8 
Fixes issue #1177 

`MapMaker#weakKeys()` makes the `Map` use identity comparison for the keys, while also enabling the automatical removal of dropped classes from the cache.

The changes are the same as in #1399, except now the original patch is modified instead of a new one being created.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aikar aikar aikar approved these changes

Assignees
No one assigned
Labels
resolution: superseded A new PR has replaced this one
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Trigary @aikar