Do not cancel chunk load on ticket level change #5978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New chunk system doesn't do cancellations anymore.
This was
linked to
issues
Jun 24, 2021
electronicboy
approved these changes
Jun 24, 2021
qixils
pushed a commit
to qixils/Paper
that referenced
this pull request
Jul 10, 2021
New chunk system doesn't do cancellations anymore. Co-authored-by: Spottedleaf <spottedleaf@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New chunk system doesn't do cancellations anymore.
https://github.com/Tuinity/Tuinity/blob/3a57f640b7c63ffcd27ab5ff2ac9e8610312f010/patches/server/0060-Do-not-cancel-chunk-load-on-ticket-level-change.patch
Tested to at least improve (but hopefully fix) #5909 and #5910 using reproduction steps provided here. I was able to cause the server to lock up and be unable to save 100% consistently within 2-30 seconds without this fix applied, and with it applied, I have not been able to lock up the server yet, and have been able to execute
/save-all flushwithout issue.