Fix command pool submitting on shutdown #8272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Now simply has a discard policy, ignoring any submitted tasks that aren't approved. |
electronicboy
approved these changes
Aug 9, 2022
Owen1212055
force-pushed
the
fix/dontsubmitonshutdown
branch
from
51aa246
to
7b95a8b
Compare
Machine-Maker
approved these changes
Aug 10, 2022
jpenilla
approved these changes
Aug 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't submit to the command pool while on shutdown.
Submitting throws an exception, might just be better to wrap it in a try catch? Unsure.