Fixup player profile getters and constructor to expected nullability #9770
Conversation
|
I think the method Server#createProfileExact should also be updated, the method specify than having one of its parameter null is valid. However when the method will find an online player and one of its parameter is null, the constructor will throw. For example: |
There was a problem hiding this comment.
The two linked issues above seems relevant and could be fixed here (even if it's a spigot one). The method SkullMeta#setOwningPlayer didn't throw before with an offline player without a name:
stack.editMeta(SkullMeta.class, meta -> {
meta.setOwningPlayer(Bukkit.getOfflinePlayer(UUID.fromString("a8179ff3-c201-4a75-bdaa-9d14aca6f83f")));
});Also this patch need to be reevaluate (https://hub.spigotmc.org/stash/projects/SPIGOT/repos/spigot/browse/CraftBukkit-Patches/0055-Fix-Player-Banning.patch): cause it can throw in the case it's still relevant
| @@ -103,16 +103,17 @@ index 0000000000000000000000000000000000000000..e513ce5bcb5070b8a57737228904381f | |||
| + @Nullable | |||
| + @Override | |||
| + public UUID getId() { | |||
| + return profile.getId(); | |||
| + return profile.getId() != Util.NIL_UUID ? profile.getId() : null; | |||
There was a problem hiding this comment.
I think doing an equals instead of a ref equality for the uuid check would be better to have a consistent state across the server since vanilla and spigot does that as well.
|
The other issues are better fixed in another pr/of lesser priority |
Changing nullability here would go beyond just getters with its creation and completion, so that feels more like a future thing