Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set project encoding to UTF-8 #1060

Closed
wants to merge 3 commits into from
Closed

Set project encoding to UTF-8 #1060

wants to merge 3 commits into from

Conversation

Plugrol
Copy link
Contributor

@Plugrol Plugrol commented Aug 15, 2023

This commit updates the build script to specifically set the project encoding to UTF-8 for JavaCompile, Javadoc, and ProcessResources tasks to ensure consistent handling of characters across different environments.

Plugrol and others added 2 commits August 15, 2023 16:30
This commit updates the build script to specifically set the project encoding to UTF-8 for JavaCompile, Javadoc, and ProcessResources tasks to ensure consistent handling of characters across different environments.
Accidentally put in java 17 instead of 11 as this is the default Javaversion I personally use 

Signed-off-by: Groldi <53694440+Plugrol@users.noreply.github.com>
@Nacioszeczek
Copy link
Member

Is there a specific issue you're encountering that this is necessary?

@Plugrol
Copy link
Contributor Author

Plugrol commented Aug 15, 2023

Yes, after cloning this repo on my arch linux (KDE) system, IntelliJ has set the wrong charset whichfor my build process crashed. However I was able to fix it with the addition I made.

@alexstaeding
Copy link
Contributor

I don't think setting the release version to Java 11 is necessary considering the toolchain is already configured for Java 11.
Also, configuring tasks should probably be done in the task block at the bottom so that the build script is a bit more sensibly organized.

As a side note, I use the same environment as you (Arch Linux, KDE) and do not have any charset issues. Are you sure you set it correctly with localectl? Verify that the output of locale shows the correct UTF-8 encoding.

@Plugrol
Copy link
Contributor Author

Plugrol commented Aug 15, 2023

My encoding seems to be correctly set to UTF-8. However I agree on the part about the java version and maybe also the placement (even I must say that this placement also is pretty structured and clearly does it job). I'll adjust this later on as I am going to be gone for a week.

@Plugrol Plugrol closed this Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants