Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use standard scroll into view method #20

Merged
merged 2 commits into from
Jun 9, 2021
Merged

Use standard scroll into view method #20

merged 2 commits into from
Jun 9, 2021

Conversation

PaperStrike
Copy link
Owner

Motivation and Context

Standard methods are always preferred.
https://developer.mozilla.org/en-US/docs/Web/API/Element/scrollIntoView

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Refactor (no bug fix and new feature but improvements)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@PaperStrike PaperStrike added enhancement New feature or request minor Pull requests that require a minor version update labels Jun 9, 2021
@PaperStrike PaperStrike merged commit e65036c into main Jun 9, 2021
@PaperStrike PaperStrike deleted the standard-scroll-into-view branch June 9, 2021 12:22
@PaperStrike PaperStrike mentioned this pull request Feb 15, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request minor Pull requests that require a minor version update
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@PaperStrike