Better namespace resolution for namespaced types #83
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #67. More specifically,
::
, by replacing them with underscores.BgInherit
structs now inherit constructors of namespaced types properly.BgJumptable
andBgInherit
structs now include any enclosing namespaces of the C++ types (because these structs are all emitted to the top-level C++ namespace).A consequence of these fixes is that namespaced types can be mapped directly:
I have also confirmed that this doesn't break qt5.cr (it merely removes a bunch of redundant
Binding::
s underlib Binding
).