Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Icon request] Updates available/System is up-to-date #2099

Closed
zorzibaffo opened this issue Mar 15, 2020 · 13 comments
Closed

[Icon request] Updates available/System is up-to-date #2099

zorzibaffo opened this issue Mar 15, 2020 · 13 comments

Comments

@zorzibaffo
Copy link

zorzibaffo commented Mar 15, 2020

Hello,

On Debian 10 with most of DE (Xfce, Mate...), there is no changing icon ("pk-update-icon" package) when system updates are available (only a short notification).

It would be great to add it.

Thanks


Icons: software-update-urgent software-update-available

@SmartFinn
Copy link
Member

All of these icons are already there. Could you add a screenshot of missing icons?

@zorzibaffo
Copy link
Author

Its seems that there's only one static papirus icon for pk-update-icon.

Icon remains unchanged, whether there are updates available or not.

Capture d’écran_2020-03-15_11-45-31

@SmartFinn
Copy link
Member

Here is a problem, software-update-urgent and software-update-available are status icons, but system-software-update is an apps icon. I can change the status icons to monochrome panel icons, but the icon for up to date state will stay a colored one.

@zorzibaffo
Copy link
Author

That means the icon would get colored only in case of updates available ? Sounds good to me.

@SmartFinn
Copy link
Member

No, the colored icon will be showing when no updates available, like on the screenshot above.

@zorzibaffo
Copy link
Author

Sorry, I had misunderstood. Do you think of a workaround ?

@SmartFinn
Copy link
Member

I don't like the current behavior and don't like the fix that mixin colored and monochrome icons. I do not know what to do. It should be changed in upstream in the perfect world.

@zorzibaffo
Copy link
Author

Some icon sets (Elementary Xfce, Obsidian...) provide two different update status(/apps?) icons.

@SmartFinn
Copy link
Member

Both of these icon themes do not provide monochrome panel icons. They don't have the issue.

@zorzibaffo
Copy link
Author

Oh, I see.

@varlesh
Copy link
Contributor

varlesh commented Mar 17, 2020

@SmartFinn It's not worked with system-software-update-panel suffix?

varlesh added a commit that referenced this issue Mar 17, 2020
… panel system-software-update-panel & software-update-available/urgent #2099
@varlesh
Copy link
Contributor

varlesh commented Mar 17, 2020

@zorzibaffo Please test it with git-version

@zorzibaffo
Copy link
Author

It looks fine now. Monochrome icon when system is up to date. Monochrome icon with a blue point when updates are available.
Big thanks, guys.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants