fix: stabilize shared with dialog (frappe#19186)

(cherry picked from commit 19588b2)

Co-authored-by: phot0n <ritwikpuri5678@gmail.com>

frappe/public/js/frappe/form/sidebar/share.js

@@ -17,9 +17,12 @@ frappe.ui.form.Share = class Share {
 			this.parent.find(".share-doc-btn").hide();
 		}
 
-		this.parent.find(".share-doc-btn").on("click", () => {
-			this.frm.share_doc();
-		});
+		this.parent
+			.find(".share-doc-btn")
+			.off("click")
+			.on("click", () => {
+				this.frm.share_doc();
+			});
 
 		this.shares.empty();
 
@@ -41,6 +44,8 @@ frappe.ui.form.Share = class Share {
 		this.dialog = d;
 		this.dirty = false;
 
+		$(d.body).html('<p class="text-muted">' + __("Loading...") + "</p>");
+
 		frappe.call({
 			method: "frappe.share.get_users",
 			args: {
@@ -52,8 +57,6 @@ frappe.ui.form.Share = class Share {
 			},
 		});
 
-		$(d.body).html('<p class="text-muted">' + __("Loading...") + "</p>");
-
 		d.onhide = function () {
 			// reload comments
 			if (me.dirty) me.frm.sidebar.reload_docinfo();
@@ -188,7 +191,6 @@ frappe.ui.form.Share = class Share {
 						}
 
 						me.dirty = true;
-						me.render_shared();
 						me.frm.shared.refresh();
 					},
 				});

frappe/share.py

@@ -82,7 +82,7 @@ def remove(doctype, name, user, flags=None):
 @frappe.whitelist()
 def set_permission(doctype, name, user, permission_to, value=1, everyone=0):
 	"""Expose function without flags to the client-side"""
-	set_docshare_permission(doctype, name, user, permission_to, value=value, everyone=everyone)
+	return set_docshare_permission(doctype, name, user, permission_to, value=value, everyone=everyone)
 
 
 def set_docshare_permission(doctype, name, user, permission_to, value=1, everyone=0, flags=None):