fix: handle 0 discussions (#9682)

Signed-off-by: Matt Krick <matt.krick@gmail.com>
ParabolInc · Apr 29, 2024 · cedc91c · cedc91c
1 parent b28ccc2
commit cedc91c
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/packages/embedder/EmbeddingsJobQueueStream.ts b/packages/embedder/EmbeddingsJobQueueStream.ts
@@ -29,7 +29,10 @@ export class EmbeddingsJobQueueStream implements AsyncIterableIterator<DBJob> {
               .orderBy(['priority'])
               .$if(!isFailed, (db) => db.where('state', '=', 'queued'))
               .$if(isFailed, (db) =>
-                db.where('state', '=', 'failed').where('retryAfter', '<', new Date())
+                db
+                  .where('state', '=', 'failed')
+                  .where('retryAfter', 'is not', null)
+                  .where('retryAfter', '<', new Date())
               )
               .limit(1)
               .forUpdate()

diff --git a/packages/embedder/WorkflowOrchestrator.ts b/packages/embedder/WorkflowOrchestrator.ts
@@ -40,7 +40,7 @@ export class WorkflowOrchestrator {
     Logger.error(error)
     const pg = getKysely()
     const {message, retryDelay, jobData} = error
-    const maxRetries = error.maxRetries ?? 1e6
+    const maxRetries = error.maxRetries ?? 10
     await pg
       .updateTable('EmbeddingsJobQueue')
       .set((eb) => ({

diff --git a/packages/embedder/workflows/relatedDiscussionsStart.ts b/packages/embedder/workflows/relatedDiscussionsStart.ts
@@ -31,6 +31,7 @@ export const relatedDiscussionsStart: JobQueueStepRun<
     // Not techincally updatedAt since discussions are updated after they get created
     refUpdatedAt: createdAt
   }))
+  if (metadataRows.length === 0) return false
   const inserts = await pg
     .insertInto('EmbeddingsMetadata')
     .values(metadataRows)