Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Sidebar in start custom activity #9647

Merged
merged 9 commits into from
Apr 29, 2024

Conversation

Dschoordsch
Copy link
Contributor

@Dschoordsch Dschoordsch commented Apr 16, 2024

Description

Fixes #9440
Make the activity detail view more reactive.

Demo

https://www.loom.com/share/f35fd5fc6a2e44fe8d5450e71d68df76?sid=c6c831d6-2dcc-4524-bb6b-4b4116cb7db5

Testing scenarios

  • open a custom activity
  • play around with the editing mode and resolutions

Final checklist

  • I checked the code review guidelines
  • I have added Metrics Representative as reviewer(s) if my PR invovles metrics/data/analytics related changes
  • I have performed a self-review of my code, the same way I'd do it for any other team member
  • I have tested all cases I listed in the testing scenarios and I haven't found any issues or regressions
  • Whenever I took a non-obvious choice I added a comment explaining why I did it this way
  • I added the label Skip Maintainer Review Indicating the PR only requires reviewer review and can be merged right after it's approved if the PR introduces only minor changes, does not contain any architectural changes or does not introduce any new patterns and I think one review is sufficient'
  • PR title is human readable and could be used in changelog

Workaround to not hide too much behind the sidebar. The activity needs
some refactoring to work in all window sizes properly.
@github-actions github-actions bot added size/s and removed size/xs labels Apr 16, 2024
Copy link
Contributor

@nickoferrall nickoferrall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and it works well

@Dschoordsch
Copy link
Contributor Author

I saw some issues in the mobile view, so this PR needs another iteration before I can merge it.

@github-actions github-actions bot added size/m and removed size/s labels Apr 18, 2024
@github-actions github-actions bot added size/s and removed size/m labels Apr 18, 2024
@Dschoordsch Dschoordsch merged commit a1658d8 into master Apr 29, 2024
5 checks passed
@Dschoordsch Dschoordsch deleted the fix/9440/customActivitySidebar branch April 29, 2024 06:53
@github-actions github-actions bot mentioned this pull request Apr 29, 2024
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: custom retro activities main view behind sidebar
2 participants