Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Refactor active meeting dropdown to get rid of some edge case bugs #9658

Merged
merged 2 commits into from
May 2, 2024

Conversation

Dschoordsch
Copy link
Contributor

@Dschoordsch Dschoordsch commented Apr 18, 2024

Description

Fixes #9272

Demo

[If possible, please include a screenshot or gif/video, it'll make it easier for reviewers to understand the scope of the changes and how the change is supposed to work. If you're introducing something new or changing the existing patterns, please share a Loom and explain what decisions you've made and under what circumstances]

Testing scenarios

[Please list all the testing scenarios a reviewer has to check before approving the PR]

  • Scenario A

    • Step 1
    • Step 2...
  • Scenario B

    • Step 1
    • Step 2....

Final checklist

  • I checked the code review guidelines
  • I have added Metrics Representative as reviewer(s) if my PR invovles metrics/data/analytics related changes
  • I have performed a self-review of my code, the same way I'd do it for any other team member
  • I have tested all cases I listed in the testing scenarios and I haven't found any issues or regressions
  • Whenever I took a non-obvious choice I added a comment explaining why I did it this way
  • I added the label Skip Maintainer Review Indicating the PR only requires reviewer review and can be merged right after it's approved if the PR introduces only minor changes, does not contain any architectural changes or does not introduce any new patterns and I think one review is sufficient'
  • PR title is human readable and could be used in changelog

@Dschoordsch Dschoordsch force-pushed the fix/9772/fixActiveMeetingsDropdown branch from 56308aa to 230e155 Compare April 18, 2024 12:50
Base automatically changed from fix/9440/customActivitySidebar to master April 29, 2024 06:53
@Dschoordsch Dschoordsch force-pushed the fix/9772/fixActiveMeetingsDropdown branch from 230e155 to 42718f0 Compare April 29, 2024 06:57
@Dschoordsch Dschoordsch merged commit 0dca699 into master May 2, 2024
5 checks passed
@Dschoordsch Dschoordsch deleted the fix/9772/fixActiveMeetingsDropdown branch May 2, 2024 07:25
@github-actions github-actions bot mentioned this pull request May 2, 2024
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix active meetings menu position on mobile/tablet
1 participant