feat: disable rate limiter in test #6146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blimmer
commented
Mar 1, 2022
| scheduleGc?: boolean | ||
| } | ||
|
|
||
| export class InMemoryRateLimiter { |
There was a problem hiding this comment.
I retained some of the changes I made in the original PR so I could just port over the unit test directly.
|
|
||
| let rateLimiter: RateLimiter | ||
| let rateLimiter: InMemoryRateLimiter |
There was a problem hiding this comment.
I found the name InMemoryRateLimiter a bit clearer, but I can change this back to just RateLimiter if you'd like.
| @@ -14,39 +14,38 @@ interface Options { | |||
| perHour: number | |||
| } | |||
|
|
|||
| const rateLimit = <TSource = any, TContext = GQLContext, TArgs = any>({ | |||
There was a problem hiding this comment.
Prettier rewrote a bunch of this, I called out the actual change below.
Comment on lines
+27
to
+29
| if (process.env.NODE_ENV === 'test') { | ||
| return | ||
| } |
There was a problem hiding this comment.
This is the only change - the requested if statement to disable in test.
Dschoordsch
approved these changes
Mar 22, 2022
|
LGTM! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supersedes #6063. Instead of choosing between a StubRateLimiter and an InMemoryRateLimiter, we just disable it when
NODE_ENVistest. See https://github.com/ParabolInc/parabol/pull/6063/files#r814362740 for details.Relates to #6018