Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use official postgres image & sync with digital ocean version #6182

Merged
merged 2 commits into from
Mar 22, 2022

Conversation

blimmer
Copy link
Contributor

@blimmer blimmer commented Mar 8, 2022

I noticed today that CircleCI started badging our builds with this warning about using deprecated images (link from screenshot).

Screen Shot 2022-03-08 at 16 35 00

We just needed to switch over to using the official postgres image vs. the circle/ prefixed one.

@@ -4,7 +4,7 @@ jobs:
docker:
- image: cimg/node:16.14.0
- image: rethinkdb:2.4.0
- image: circleci/postgres:12.3
- image: postgres:12.3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 We should probably just switch to cimg/postgres:12.9 instead

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should use cimg/postgres, we recently moved the node image to cimg/node as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's usually nice to sync up this version with what's being used in production. I see at least 12.3 and 12.5 defined in the project. Any idea what would version best reproduce what we're running in prod?

Screen Shot 2022-03-15 at 09 02 30

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just FYI, we are actually at 12.10 on DO, looks like 12.9 is the closest. We should be fine to use cimg/postgres:12.9

Copy link
Contributor Author

@blimmer blimmer Mar 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha, so would it make sense to sync all of these version specifications up to 12.10? I'm not sure if DO is the only hosting provider for postgres across SaaS and on-prem.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. I'll update the local docker setups to use postgres/12.10 and this to use cimg/postgres:12.9 until they merge this change: CircleCI-Public/cimg-postgres#42

@blimmer blimmer force-pushed the fix/circleci-convenience-image branch from 78b8f7e to 6ff1c9f Compare March 15, 2022 16:18
@blimmer blimmer changed the title ci: use official postgres image ci: use official postgres image & sync with digital ocean version Mar 15, 2022
@blimmer blimmer merged commit 55e4213 into master Mar 22, 2022
@blimmer blimmer deleted the fix/circleci-convenience-image branch March 22, 2022 17:04
@adaniels-parabol adaniels-parabol mentioned this pull request Mar 25, 2022
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants