-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: use official postgres image & sync with digital ocean version #6182
Conversation
.circleci/config.yml
Outdated
@@ -4,7 +4,7 @@ jobs: | |||
docker: | |||
- image: cimg/node:16.14.0 | |||
- image: rethinkdb:2.4.0 | |||
- image: circleci/postgres:12.3 | |||
- image: postgres:12.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 We should probably just switch to cimg/postgres:12.9
instead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should use cimg/postgres, we recently moved the node image to cimg/node as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just FYI, we are actually at 12.10 on DO, looks like 12.9 is the closest. We should be fine to use cimg/postgres:12.9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gotcha, so would it make sense to sync all of these version specifications up to 12.10? I'm not sure if DO is the only hosting provider for postgres across SaaS and on-prem.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good. I'll update the local docker setups to use postgres/12.10
and this to use cimg/postgres:12.9
until they merge this change: CircleCI-Public/cimg-postgres#42
78b8f7e
to
6ff1c9f
Compare
I noticed today that CircleCI started badging our builds with this warning about using deprecated images (link from screenshot).
We just needed to switch over to using the official postgres image vs. the
circle/
prefixed one.