Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update CONTRIBUTING #6432

Merged
merged 3 commits into from
Apr 25, 2022

Conversation

shapel
Copy link
Contributor

@shapel shapel commented Apr 21, 2022

This PR introduce a new section on CONTRIBUTING describing the step by step guide how to make changes (including code review flow described by @nickoferrall in Slack).

@shapel
Copy link
Contributor Author

shapel commented Apr 21, 2022

👋 @nickoferrall would you mind to review this?

Copy link
Contributor

@Dschoordsch Dschoordsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking the time to update this documentation!

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
Copy link
Contributor

@nickoferrall nickoferrall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this change!

@nickoferrall nickoferrall merged commit efa5230 into ParabolInc:master Apr 25, 2022
atannus pushed a commit to atannus/parabol that referenced this pull request Apr 26, 2022
* docs: add list of maintainers

* docs: add making changes section

* docs: update steps to keep clean git history
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants