Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fetch CORS resources from network #9586

Merged
merged 1 commit into from
Apr 2, 2024
Merged

fix: Fetch CORS resources from network #9586

merged 1 commit into from
Apr 2, 2024

Commits on Apr 2, 2024

  1. fix: Fetch CORS resources from network 

    If we fetch our own assets we want a CORS response to properly cache it
in the service worker. If the response is served from the browser cache
however, then there is a high chance that the required response headers
are missing and the browser responds with a CORS error instead of
refetching the resource. This happens because the Vary header does not
include headers not present in the original request.
To avoid this error, always fetch from the network for requests we
intend to cache in the SW.
    @Dschoordsch
    Dschoordsch committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    cd552c4 View commit details
    Browse the repository at this point in the history