Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Optimize processRecurrence #9670

Merged
merged 3 commits into from
Apr 30, 2024
Merged

Conversation

Dschoordsch
Copy link
Contributor

@Dschoordsch Dschoordsch commented Apr 24, 2024

Fixes #9664

MeetingSeries related dataloaders were loading data one by one instead of batching resulting in more roundtrips.

Testing scenarios

  • create many meeting series for example by running
    for i in {1..100}; do yarn workspace parabol-server test process; done
    
    (Note that these fail in signup for lack of randomness in faker after many iterations.)
  • Run processRecurrence and don't see any errors

Final checklist

  • I checked the code review guidelines
  • I have added Metrics Representative as reviewer(s) if my PR invovles metrics/data/analytics related changes
  • I have performed a self-review of my code, the same way I'd do it for any other team member
  • I have tested all cases I listed in the testing scenarios and I haven't found any issues or regressions
  • Whenever I took a non-obvious choice I added a comment explaining why I did it this way
  • I added the label Skip Maintainer Review Indicating the PR only requires reviewer review and can be merged right after it's approved if the PR introduces only minor changes, does not contain any architectural changes or does not introduce any new patterns and I think one review is sufficient'
  • PR title is human readable and could be used in changelog

MeetingSeries related dataloaders were loading datums one by one instead
of batching resulting in more roundtrips.
Add a check as an insurance that the dataloader does not mix up data.
@Dschoordsch Dschoordsch merged commit eb6e608 into master Apr 30, 2024
6 checks passed
@Dschoordsch Dschoordsch deleted the fix/9664/optimizeProcessRecurrence branch April 30, 2024 06:58
@github-actions github-actions bot mentioned this pull request Apr 30, 2024
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chronos error on mutation ProcessRecurrence
2 participants