/vg/ multitool menu port & more buildable atmos equipment #12
Conversation
ports VG multitool menus, and moves Tcomms to them ((think of multitool menus as the menu you get when you use a multitool on Tcomms equipment))
|
vents done, you can now change frequency and ID tag on them |
|
scrubbers done |
|
gas sensors, done, working on consoles that can use 'em |
|
air injectors |
PJB3005
changed the title
|
Gas sensors and Air injectors buildable & multitool menu done |
|
Looking mighty delicious 🌚 💯 |
|
Thanks Mark couple of atmos consoles, using this PR you should be able to rebuild the big atmos tanks |
|
Will this also allow you to create new airlocks? |
|
cycling ones? yes, once I get to porting that over, currently focusing more on atmos equipment |
|
Atmos automations console, A.K.A. scripting atmos My completely not rushed super air conditioner for atmos, once the temp goes above 350°K, it opens up a vent connected to a cooled N2 canister, closes it when the room temperature reaches 290°K also I didn't copy the sprite yet |
|
This looks very fun, can't wait to mess around with it. Having more automation would be really useful. |
|
Does it work with the shuttle controller we run? |
|
Sam, I didn't get to the cycling airlocks yet, I'll figure something out for that part, as /vg/ has no cycling airlocks prebuild on the map, and no support to use them for shuttles, not to mention /vg/ doesn't have things like shuttle "docking" |
seriously why be a snowflake attackby()
|
You'll have to let Fox know when it's ready for merging. |
|
yeah, I know, been kinda procrastinating and stuff, gonna have to fix that damn merge conflict too |
seriously some VG code was even broken
|
So apperently this PR went from multitools to JSON code upgrades, okay then |
GITHUB STOP BEING SHIT
|
*goes insane about merge conflicts |
|
Fix the merge conflicts, make sure it's fox.dm and not Fox.dm in the dme for consistency and I'll make sure it's merged promptly this time. |
|
done! |
|
We still need to discuss this at length; could you please notify me (here or on the forums) of what day would be a good time? |
|
I'm not the kind of person that's good with specific moments, it's probably just best if we ping eachother on IRC when it's convenient |
ZomgPonies
added
Feature
…o vg-masterrace Conflicts: code/game/machinery/machinery.dm code/modules/nano/_JSON.dm code/setup.dm
…ting) in multitool menu code, which I recently discovered.
past me, why the snowflaking
…act with vents or scrubbers, the vents or scrubbers in question need to have a setting switched in their multitool menu, now you can't nuke every vent and scrubber on the station to syphon with them anymore
…o vg-masterrace Conflicts: code/game/machinery/atmoalter/meter.dm
fixes an oversight that can cause multitools to not work with multitool menus anymore (runtime error related) sanity checks added to AAC
|
We've discussed the matter, and we've come to the conclusion that we'd rather not implement this feature on the server. The feature effectively allows you to do anything you want with the atmospherics system, as long as you have the board and know how to code. However, this knowledge is limited to a select number of people, and will probably not be used much, while those who do know how to use it will have a major advantage over others. While there's certainly a lot of "difficult" features in the game, we'd rather avoid adding another feature that requires extensive OOC knowledge. If you'd like a more in-depth explanation, feel free to contact me/Fox/Ponies personally. |
|
really? rip 2500 lines of code ;_; |
|
would it still be unbalanced if I removed the AAC? Also programming the AAC is easier than programming a lego mindstorms, i'm not a genious with atmos but even I can comeup with cool sit for the AAC, if this is unbalaned because it's an "OOC knowledg" thing then we can get ridof atmos, NTSL and toxins while we're at it |
|
@PJB3005 for what it's worth, I would love to see this again now that we have LINDA dunno how much that is worth tho |
|
go ahead and reopen it, but I'm not coding anything for it anymore. if you want to make a PR to my fork or something go ahead. |
PJB3005
changed the title
made the hallway smaller
Update 29/11/22 [MDB IGNORE] [IDB IGNORE]
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> ## What Does This PR Do <!-- Include a small to medium description of what your PR changes. --> <!-- Document all changes, as not doing this may delay reviews or even discourage maintainers from merging your PR! --> <!-- If your PR fixes an issue, add "Fixes ParadiseSS13#1234" somewhere in the PR description. This will automatically close the bug upon PR submission. --> * Changes default keybindings to SS220 * Adds translation to keybindings ## Why It's Good For The Game <!-- Add a short description of why you think these changes would benefit the game. If you can't justify it in words, it might not be worth adding. --> Easier transition from old para ## Changelog :cl: add: Default Keybindings from SS220 /:cl: <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. --> <!-- If a PR has no impact on players (i.e. a code refactor that does not change functionality) then the entire Changelog heading and contents can be removed. --> --------- Co-authored-by: Furior <68264134+Furrior@users.noreply.github.com>
ports /vg/ multitool menus, makes a lot more atmospherics equipment buildable & configurable with multitool menus (vents, air injectors, sensors, DP vents, Dvalves, etc...)
AAC: scripting atmos