Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Body Accessory system #1472

Closed
wants to merge 5 commits into from
Closed

Conversation

tigercat2000
Copy link
Contributor

This commit adds a new system to character setup: Custom, selectable tails. body accessories. This means that anyone can select a tail body accessory if it is available to their race, and it will properly show up. Important note: If no tail body accessory is selected, the species default tail body accessory will be used.

Oh. Right. Going to point out this needs an SQL update if it's merged.

OUTDATED INFO:

There are currently only testing-tails, so DNM until sprites.
Included tails as of now:

  • Tajaran tail for all mobs
  • Restricted Tajaran tail for tajarans
  • Body class, Snake body

Pictures
i'm pure evil, aren't I?

Updated:
All species with tails now use a tail datum. The testing tails for humans have been removed, and normal players will see an empty menu.

Other things:

  • Added more creepy-body sprites
  • Species now use the tail datum system as well.
  • Removed tail_wagging flag, because it shouldn't really matter if the species supports it; the important part is if the tail has an animated state.

Picture:
oh god

Well the maintainers are boring. So this is now just a tail datum system. No fancy bodies or anything.

@Fox-McCloud
Copy link
Member

Ok, first things first....

  • (1) Absolutely no snake people or other such things; this PR should be limited to tails only
  • (2) Tails should be restricted to their respective mobs and that's it; absolutely no cross-species with non-species tails or out of species tails/etc.
  • (3) All current species with tails (Vulpkanin/Unathi/Tajarans) should utilize this system for future customization if so desired.
  • (4) I strongly recommend moving all tail related sprites into their own .dmi so that it's far easier to maintain.

@Fox-McCloud Fox-McCloud added Do Not Merge This PR must not be merged or closed Feature This PR is a new addition to the game labels Jul 8, 2015
@tigercat2000
Copy link
Contributor Author

@Fox-McCloud Alrighty, will fix as soon as I wake up.

@Earthdivine
Copy link
Contributor

I was honestly like the snake tails kept in as admin stuff for now, sounds like a fun thing for us to mess with.

@ZomgPonies
Copy link
Contributor

I like the idea of weird, admin-event tails like the snake tail that could be linked to special/custom bodyparts/external organs, but that should probably go in a separate PR.

…cies

tail system

The body class of the accessories is now admin-only, and can only be
selected by people with R_ADMIN, with a clear warning that they are for
admins.

More sprites from V.O.R.E. Station have been added and made into datums:
Specifically,
 - Wolf body
 - Horse body
 - Cow body
 - Lizard body
 - Spider body

Added a system for restricting certain tails to admins.

Removed testing tails; Non-tailed races will currently see nothing, unless
they are an admin, in which case they will see admin options.
@tigercat2000 tigercat2000 changed the title Selectable tail system Body Accessory system Jul 8, 2015
@TheDZD
Copy link
Contributor

TheDZD commented Jul 8, 2015

The sprites for the snake, horse, and spider body parts look pretty bad. Wait a minute... My god these are Vorestation sprites.

my eyes

@Spacemanspark
Copy link
Contributor

Uhhhh what.

@TheDZD TheDZD added the WTF BYOND will never cease to amaze and/or disappoint us label Jul 8, 2015
@FreeStylaLT
Copy link
Contributor

yes please

I want my lamia booty

@Aurorablade
Copy link
Contributor

adminbus or viruses....CAN I MAKE THEM VIRUSES?!

@Fox-McCloud
Copy link
Member

Save the "body sprites" for a separate PR where they can be debated, separately. Most of the sprites look like absolute trash and are creepy as hell; again, this should be a tail only PR if you want to get this merged.

@tigercat2000
Copy link
Contributor Author

@Fox-McCloud I don't see why you would want this to be a tail only PR. Isn't the entire point customization? The system has been designed from the ground up to work with literally any icon you define, and now the body sprites are for adminabuse-only as @Earthdivine, @FreeStylaLT, and @ZomgPonies expressed interest in.

@Fox-McCloud
Copy link
Member

Yes, and he expressly stated that it should be a separate PR, as well and didn't see how gosh damn awful those sprites are.

We're not vorestation and THAT kind of customization isn't something we should be utilizing here on Paradise; there's a stark difference between being able to just customize your own tail, and gluing on a horrendously blended "body" overlay to the bottom part of your sprite.

@tigercat2000
Copy link
Contributor Author

@Fox-McCloud I don't see a single bit of difference between letting all the tailed-races have custom tail sprites and letting admins have abuse sprites for creepy events.

@Fox-McCloud
Copy link
Member

@tigercat2000

Save it for another PR--likewise, it should be on a whole separate layer from tails, otherwise its going conflict with tail wagging and also cut short use of potential non-awful body customized sprites.

IF this is going to be a "thing" it should:

  • (1) Be in a separate PR where it can be debated separately
  • (2) Not be on the same layer as tails

There's a world of difference; it's fairly natural for those species to have tails---having horrifying glued on bodies of other animals that are horrendously blended is a whole different story.

@tigercat2000
Copy link
Contributor Author

Requesting @TheDZD's input, might as well get all the maintainers.

And @Fox-McCloud, I see your point.

@TheDZD
Copy link
Contributor

TheDZD commented Jul 8, 2015

👍 to the datum-based tail system.
👎 to the weird animal bodies, partly because they look weird being glued on to a species, and partly because the sprites are low quality.

@KasparoVy
Copy link
Contributor

Woah woah what the deuce
spooked me a little bit actually with some of those pictures. big ups for putting an armalis in there lmao

IDK what to say this is pretty cool bruh. Sounds like the tail bit and the possible customization associated with it in future implementation would be absolutely bomb 👍

"Added more creepy-body sprites @Earthdivine @ZomgPonies Made them admin-only; Only admins with R_ADMIN will be able to select them."

Sounds like all is as it should be to me

@Aurorablade
Copy link
Contributor

Tarajan/Vulpakanin/Unathi/Vox Tail jewelery? EH EH?!

@KasparoVy
Copy link
Contributor

^^^^

Yeah, that's what I'm thinking.
Vox tail quills ;)

@Fox-McCloud
Copy link
Member

Just a few more suggestions:

  • rename it from body accessory to tail (in the character creation anyway)
  • move all tail related sprites to a singular.dmi please. Hair accessories follow this pattern; so should tails.
  • is the commented out code for "if no tail is found, do this" necessary anymore?

@tigercat2000
Copy link
Contributor Author

I'm closing this. I don't really want to continue any work on it, and there are more reasons that I don't particularly want to elaborate on.

@tigercat2000 tigercat2000 deleted the evillaugh branch July 9, 2015 20:00
@tigercat2000 tigercat2000 restored the evillaugh branch July 9, 2015 20:05
@KasparoVy
Copy link
Contributor

Quite a few people'd love to have atleast the tail bit/framework in for customization at the very least. Is it worth axing the whole thing just because one part was disagreed with?

@tigercat2000
Copy link
Contributor Author

@KasparoVy It wasn't closed for just that reason.

@KasparoVy
Copy link
Contributor

@tigercat2000 Either way, I'm going to miss this PR :(
Quite sorry it didn't work out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Do Not Merge This PR must not be merged or closed Feature This PR is a new addition to the game WTF BYOND will never cease to amaze and/or disappoint us
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants