New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alternate tail/body/whatever-can-fit-on-the-tail-layer system #1997
Conversation
This commit adds a modular system for selectable body accessories. These accessories are currently split into two primary groups, "/body_accessory/body" and "/body_accessory/tail", for "body" sprites and "tail" sprites respectively. (also known as a subtype just for vorestation taur sprites) Basically, this allows for selectable tails. This commit doesn't include any subtypes, which will cause the startup hook to fail. The only subtypes this actually includes is a snake 'body'. Admins can select any tail, regardless of species restriction. Admin-only subtypes are simply defined by not adding any species to the whitelist. Note, as this system uses the body color system, admins may also use the body colors at any time regardless of race.
Conflicts: SQL/paradise_schema.sql code/modules/client/preferences_mysql.dm
I suppose I should tag everyone who cared about the last PR. |
I still don't like the snake body sprite, but considering that this has tails in it and the snake body is locked as admin only, I'm willing to compromise on that. 👍 |
Didn't ping me Tiger, rude. It might help that I didn't talk in the last PR last time at all. |
Oh cool! Pillaging snake bodies from VORE Station? Hope you guys like 'em! Provided, the sprite does need improvement. If you make a better one, we may counter pillage if you don't mind. 👍 Ping me if you guys get better sprites for 'em. |
... |
@Nienhaus Apparently the participants list also includes anyone mentioned. Whoops. |
What do you mean also includes? I wasn't pinged :c |
I think DZD pinged you. |
That didn't put me in the participants though. |
I just get an email about every PR. |
Oh. I'm just crazy, then. Oh well. Sorry. |
heresy |
So I want to understand what this means. Mobs with a tail layer can pick different tail types, except for the snake tail. Admins can insert a tail layer on to any mob to give it a tail and thereby also the snake body if they so please. |
@taukausanake Your name is super close to snake at the end, are you a snake in disguise? |
@taukausanake Kindof. Everything is handled via character setup. Admins can select snake tails for their own character slots, but it would take a significant amount of fucking with varedit to give someone else a tail or body. |
@Nienhaus Nope. I understand that it sounds like it would but I made that name YEARS ago. Like, before I even realized it sounded Naruto-like :/ |
I got my eye on you @taukausanake |
I would be up for a tail system for slime and ipc's too, also bionic tails, cause there are rumours of making it possible to loose em from damage and whatnot. |
literallyusingvorestationsprites |
@Robertha89 Technically possible with this, just would need sprites |
is is that a fucking glowy lightsaber tail |
@Flip-Sandwich I was thinking it looks more like a skunk tail but I know I'm wrong. Maybe super fluffy tail? |
If it would be possible to restrict neon color i would support it. I don't think we should take races back, but keep limiting all this fluff around them. I literally played vox for years with one hairstyle and no colors and miss fitting items everywhere it's not that difficult. It's ridiculous what's going on to the station, we are inviting everyone who is not taking this game serious in anyway. Furries, pet murdering hobos, suicidal persons everywhere. It's like a shift in arkham asylum. Don't get me wrong some rounds are fun, but too many just derail and go down the drain. |
It's really only the snake body that needs replaced. |
I don't mind anything else other than those damn fucking snake tails jesus christ why do we still have them in this PR AAAAAAAAAAAAAAGHH |
This is almost better than the fight /tg/ had over some extra dirt. |
Can someone please explain to me why they think that having more sprite and color selections somehow increases bad behavior? Because as far as I was aware people who are going to be creepy/suicidal/rude/gross/etc are going to do so because that is how they want to act in game and it is not at all influenced by having or not having certain items/races/colors/etc. Why does an anthropomorphic animal being able to be blue and have a alternate tail suddenly change them into a terrible player but a human with the same shade of blue hair, kitty ears and a schoolgirl outfit not cause the same sort of magical transformation into a terrible player? Both situations cater to different fandoms and both have their fair share of erotic and obnoxious behavior but for some reason we're not lumping all that in with this too? From what I've been reading and seeing from this "community" it wouldn't matter even if all races had to be realistic because people would still have some personal issues and insecurities revolving around things they don't like. I think the bigger issue here is that this community seems incapable of not lumping people into generalized groups. People see what they want to see, they focus on a tiny handful of negative experiences and apply them to an entire group and state "All of (insert race here) is bad! they all (actions you don't like here)". Maybe you're right, maybe some people do that thing you don't like but that doesn't mean they all do and the answer isn't to remove and deny things from people who aren't doing anything wrong. I'm always for more customization and I could try making you lot a naga tail if this gets implemented. |
@Fullofskittles I was going to redo the snake/nega tail but it'd be cool if you did it because I was going to be lazy and not do it for a few days. |
With whom do you want this reputation? While I am all for removing creepy folks I need that to be better defined, if this is about pleasing that message board I am thinking of, well then I don’t care. Anyways it seems like with the sprites for the snake tail being redone internally anyways, we are now going to be free from other server code. I know this will not entirely remove the drama but at least it makes it easier for me to discount it.
We have been at this level for some time now, the reason for it probably has little to do with species. Although we could do the following,
After we did this would we be a high-tech space station simulator? I think it would help with immersion perhaps, but this is implemented in many servers already by simply not having non-human species. Many of those servers I have noticed are a bit more into the space hobo Ian murdering end of the spectrum then we are. 👍 My list (Immersion) |
/datum/body_accessory/proc/try_restrictions(var/mob/living/carbon/human/H) | ||
return 1 | ||
|
||
/datum/body_accessory/proc/get_pixel_x(var/mob/living/carbon/human/H) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This... doesn't really need to exist.
same for it's Y counterpart, and actually adds a small about of lag to obtaining that var (because of the proccall)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's in place for anything that needs special handling depending on the human it's attached to, I suppose I could remove it until something of the sort is actually a thing, though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah I get -why- it might be needed in the future, but atm it's literally inefficiency personified.
Re-read over my previous comment and realized that the second part of it came off as a bit hostile towards the new tails, so I would like to clarify that I'm fine with the customizable tails, and just wanted to point out the tendency of people creating ridiculous-looking neon-colored characters. While this system could later on be used to exacerbate that, I don't think that it does in its current state. If you are able to get a new sprite for the snake body, I would be fine with it considering it is admin only. I am aware of the fact that there are a few irritating/bizarre/downright creepy Vulpkanin/Tajaran characters, but those need to be dealt with on an individual basis and just need to be told to cut the creepy shit (for those not aware, you don't want to know). I am also aware of the fact that Paradise has a reputation for being a furry server due to a few of the races, which to some extent leads to problem players as mentioned before. That said, changing the perception isn't exactly something that can be done overnight, and any additions that might seem to be catering to furries will be taken as evidence of it being a furry server. People who ERP will be banned, people who furry ERP will be banned, people who do freaky shit should be warned to stop doing so/be banned if they continue. People who cry fursecution will be directed to this image and be told to sod off. People who are assholes and grief players/the server because "lel furries" will be treated the same way, with the addition of having their asses banned. As an aside, if you are not going to contribute to the discussion (à la popcorn comments) the code contained with this PR, or are simply going to make ad hominem attacks against certain people then refrain from commenting at all. I am not in the mood for another pointless shitstorm and the discussion will be locked if it starts to become one. |
To be quite honest, I don't hold an opinion on whether or not the snake tails should be included. Frankly, I think they are rather disconnected from the rest of the game and races, but don't believe that is necessarily a valid ground to build an opposition off of. As I stated in the coder chat while discussing this: The snake tails honestly are not as big a deal as everyone makes them out to be, simply because they are locked to admin-only use (just like Wryn, Nucleation, and Vox Armalis). If an admin makes a habit of utilizing them on a frequent basis, then the admin in question is going to get investigated for abusing their powers, same as if they regularly played any of the admin-only races outside of events. As for the tails system, this was something that was wanted since before the release of Vulpkanin. When the original sprites for the race were being made, there was a desire that they would be able to select different tails related to different species/breeds of canines in order to help signify it was a generic dog race (and not a fox race as many people believe). However, lacking the system to support such options at the time, this was dropped into limbo until Tiger made this PR. People who are going to be "that creepy, furry, borderline-ERPer" are going to be that with or without access to neon colors, different tails, or schoolgirl skirts. As a community, we have set in place and enforce rules regarding behaviors, and adding new options for character creation will not change this. Anyone who attempts to use these new tails as an excuse or enhancement to ERP is going to be met with the same response as before this PR was even proposed: admin-induced harassment and banning. We are not Vorestation. We are not Citadel. We are not TG. We are Paradise, and we do not allow ERP. Tails will not change this. 👍 |
Honestly this is an odd issue to even be this controversial, I mean honestly, this is quite silly really. So what if you got neon-colored tajarans with helicopter propellar tails, why does it matter, if they erp, they break the rules, there should be no issue. All issues so far are an ingame issue rather then an code issue... Hey, how about this, how about we put the code in, try it out for a week or 2, and then check what people want? |
@Robertha89
No, I am strongly against it because it literally won't be reverted even if the entire community ups and leave the server. |
Y'know it's real awkward when the only reason is "Because furries." If people are gonna ERP, they already will via third party clients, this changes nothing and the snake part is admin only so even MORE of a non-issue. |
@Dinarzad To be fair, they are shit sprites. Sorry @SpadesNeil. |
I would agree. The other reasoning though is what makes it kinda awkward. |
Yes. We want them to not ERP here on SS13.
Furry isn't a sexual orientation. |
Not isn't, but the principle of it is pretty damned similar. But to have that be the sole line of reasoning is... eyebrow raising and I would be remiss if I did not at least say so. I did, so that's pretty much where Imma drop it. |
The real question is, at what point is extended customization hurting a game instead of enriching it? And i think this point is reached when players actually feel uncomfortable around other characters. It's not so much about this specific PR but the general route this server is taking. It's the sum of PRs is what makes the difference and at some point you have to stop. |
I doubt it was the intent of anyone involved with the PR to create an unwelcoming atmosphere or to make anyone uncomfortable. I am not happy with all the characters people choose to play on the server, but I believe that this will not make anything worse and will add some features that have been talked about for some time in terms of tail customization. Its not just a group we don't want hanging around that could benefit from this. The type of players who take the game seriously, play the roles they have chosen and make a more enjoyable experience for the players they interact with are going to use this also. It seems an assumption has been made about what exactly this enables, and I can't do anything other then to refer to @Fullofskittles post as they cover my thoughts on that part better then I could. |
No better way it could've been said tbh Also, if a character makes you uncomfortable, is it not the case most often where you just hold down a button and move away from them? Is not responding, paying attention, etc. an option still? To force focus on that which annoys/bothers you so much makes little sense since there's much else you could be doing. I'd like to go far as to say that if, for example, an incomprehensibly stuttering teal/magenta/whatever Tajaran/Vulpkanin/Slime/Anything with behavioral issues makes you cringe then pay attention to something else but judging by some of the responses this option seems almost out of the question I'm still 'bout the feature. It's been interesting (but mostly entertaining) to see how the discussion's gone |
👍 |
You hold down the button and move away from them, and then you either run into more of the same problem or they start spreading their bullshit over general comms. |
@@ -366,10 +367,14 @@ datum/preferences | |||
dat += "<br><b>Eyes</b><br>" | |||
dat += "<a href='?_src_=prefs;preference=eyes;task=input'>Change Color</a> <font face='fixedsys' size='3' color='#[num2hex(r_eyes, 2)][num2hex(g_eyes, 2)][num2hex(b_eyes, 2)]'><table style='display:inline;' bgcolor='#[num2hex(r_eyes, 2)][num2hex(g_eyes, 2)][num2hex(b_eyes)]'><tr><td>__</td></tr></table></font><br>" | |||
|
|||
if(species == "Unathi" || species == "Tajaran" || species == "Skrell" || species == "Slime People" || species == "Vulpkanin") | |||
if(species == "Unathi" || species == "Tajaran" || species == "Skrell" || species == "Slime People" || species == "Vulpkanin" || body_accessory_by_species[species] || check_rights(R_ADMIN, 1, user)) //admins can always fuck with this, because they are admins |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Second parameter probably needs to be a 0. It shouldn't notify the user of a lack of rights if that check fails.
Alternate tail/body/whatever-can-fit-on-the-tail-layer system
Remake of #1828, bringing back stuff from #1472, with a completely different back end, and a slightly different intent.
This system allows players to choose an alternate tail sprite (from a list of pre-made datums) for any species that has a pre-made datum. It also allows for admin-only things.
Basics:
Screenshots:
Previous PR, sprites still apply.
New stuff from skittles!