Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Entertainer Drip (Mime/Clown) #23546

Merged
merged 2 commits into from Dec 28, 2023
Merged

Entertainer Drip (Mime/Clown) #23546

merged 2 commits into from Dec 28, 2023

Conversation

Christasmurf
Copy link
Contributor

@Christasmurf Christasmurf commented Dec 13, 2023 •
edited

What Does This PR Do

Ports the mime outfits from tg tgstation/tgstation#64433
Minor resprite for the clown (better shading), addition of a clown skirt. Rebrands the sexy clown outfit.
Resprites the clown backpack/duffel, adds a clown satchel

Species sprites for the sexy outfits made by Synth

Why It's Good For The Game

Better looking sprites

Images of changes

Before:
image

After:
image
(The mime uniform/skirt can be rolled down)

Bags:
image

Duffelbag item change for better shading
image

Testing

Spawn in and check lockers, wear outfits with magic mirror for species sprites

Changelog

馃啈 Christasmurf, Synth
add: Added clown skirt, clown satchel, ported mime skirt
imageadd: Ported mime jumpsuit/sexy from tg, resprited clown sexy, minor touch-ups to clown uniform + bags resprited
/:cl:

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally Sprites This PR modifies the game sprites labels Dec 13, 2023
@PhantornRU
Copy link
Contributor

The previous outfits are good. It's better not to delete them, but to create new objects with new/old sprites.

@Henri215 Henri215 added the Requires Wiki Update Useful for Wiki Contributers to search for things that need updating label Dec 13, 2023
@Christasmurf
Copy link
Contributor Author

The previous outfits are good. It's better not to delete them, but to create new objects with new/old sprites.

The previous outfits are old, and crusty, and people have expressed a desire to see them change because of how bad they are. If you wish to keep them for personal use, download them from the repo now because I have no intention of keeping them with this PR.

@Probablyjay19
Copy link
Contributor

The previous outfits are good. It's better not to delete them, but to create new objects with new/old sprites.

The previous outfits are old, and crusty, and people have expressed a desire to see them change because of how bad they are. If you wish to keep them for personal use, download them from the repo now because I have no intention of keeping them with this PR.

Sadge, although I will miss the female mime performer outfit, that one is actually baller.

Henri215
Henri215 approved these changes Dec 14, 2023
View reviewed changes
Copy link
Member

@Henri215 Henri215 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LHTM (Looks Honkable To Me)

code/modules/clothing/under/jobs/civilian.dm Show resolved Hide resolved
Burzah
Burzah approved these changes Dec 14, 2023
View reviewed changes
Copy link
Member

@Burzah Burzah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honk

@spacegeese
Copy link
Contributor

How does this look with the completed clown outfit?

@Christasmurf
Copy link
Contributor Author

Christasmurf commented Dec 15, 2023 •
edited

How does this look with the completed clown outfit?

image

image

image

masks and shoes are unchanged

@spacegeese
Copy link
Contributor

HOLY SHIT
image
IT'S THE FUCKING
FUCKING LAWYER CLOWN

@SteelSlayer SteelSlayer added the Feature This PR is a new addition to the game label Dec 15, 2023
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting approval This PR is waiting for approval internally and removed -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally labels Dec 15, 2023
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting merge This PR is ready for merge and removed -Status: Awaiting approval This PR is waiting for approval internally labels Dec 19, 2023
@hal9000PR hal9000PR merged commit 95c4666 into ParadiseSS13:master Dec 28, 2023
11 checks passed
Oyu07 pushed a commit to Oyu07/Paradise that referenced this pull request Jan 2, 2024
@Christasmurf @Oyu07
Entertainer Drip (Mime/Clown) (ParadiseSS13#23546)
8df0908 
* entertainerdrip

* duffelshadingitem
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hal9000PR hal9000PR hal9000PR approved these changes

@Henri215 Henri215 Henri215 approved these changes

@Burzah Burzah Burzah approved these changes

Assignees
No one assigned
Labels
-Status: Awaiting merge This PR is ready for merge Feature This PR is a new addition to the game Requires Wiki Update Useful for Wiki Contributers to search for things that need updating Sprites This PR modifies the game sprites
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@Christasmurf @PhantornRU @Probablyjay19 @spacegeese @hal9000PR @Henri215 @Burzah @ParadiseSS13-Bot @SteelSlayer