Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mime Resprites, AKA Mime Desouling #64433

Merged
merged 4 commits into from Jan 27, 2022

Conversation

axietheaxolotl
Copy link
Contributor

About The Pull Request

See the tin.

mimepreview

Resprites the jumpsuit (done by @Imaginos16), Parcel Parceaux, skirt.

Also, I've changed the old sexy outfit for a new one.

image

This is also a good time to show off the new lace-up sprites I did, which you can see there.

Why It's Good For The Game

The old mime stuff was fucking ancient. This is better.

image

Changelog

🆑
imageadd: New sprites for the Parcel Parceaux, base Mime mask, Mime outfit and skirt, and mime sexy outfit.
imageadd: new sprites for lace-up shoes.
code: Mimes spawn with lace-ups instead of black shoes
/:cl:

@tgstation-server tgstation-server added Code Improvement Code is now easier to copy paste. Merge Conflict Adding upstream files to your repo via drag and drop won't resolve conflicts Sprites A bikeshed full of soulless bikes. labels Jan 26, 2022
@thgvr
Copy link
Contributor

thgvr commented Jan 26, 2022

The Soul Sucker claims another victim. Looks great.

@tgstation-server tgstation-server removed the Merge Conflict Adding upstream files to your repo via drag and drop won't resolve conflicts label Jan 26, 2022
@cacogen
Copy link
Contributor

cacogen commented Jan 26, 2022

Sprite PRs should be required to provide a comparison to the sprites that they're changing. IconDiffBot's output is too small to see the differences clearly, and sprites look different in the game itself. But from what I can see there, these sprites just look like a less shaded version of the old ones. Might be better, might be worse. Can't tell.

Oh, and you deleted the back sprite for bamboo spears.

@MaineTheMan

This comment has been minimized.

@MaineTheMan

This comment has been minimized.

@axietheaxolotl
Copy link
Contributor Author

also, the sexy outfit looks more like a black and white cartoon version of mario, not at all sexy.

he doesn't know

@axietheaxolotl
Copy link
Contributor Author

Sprite PRs should be required to provide a comparison to the sprites that they're changing.

I literally showed the old sprites. Do you actually have eyes?

@MaineTheMan

This comment has been minimized.

@MaineTheMan

This comment has been minimized.

@Imaginos16

This comment has been minimized.

@bluetshirtguy

This comment has been minimized.

@JohnFulpWillard

This comment has been minimized.

@Iamgoofball
Copy link
Contributor

why does the mime look like mario

@axietheaxolotl

This comment has been minimized.

@JohnFulpWillard

This comment has been minimized.

@necromanceranne

This comment has been minimized.

@axietheaxolotl
Copy link
Contributor Author

It's so subtle as to be a 'you know if you know' kind of reference.

If people would otherwise know of it, it would be the SFW stuff instead :P

^

@jughu
Copy link
Contributor

jughu commented Jan 26, 2022

Dont turn the mime into a mickey mouse ass looking

@bluetshirtguy

This comment has been minimized.

@SomeDongus

This comment was marked as abuse.

@Sealed101

This comment has been minimized.

@tgstation tgstation deleted a comment from MaineTheMan Jan 26, 2022
@tgstation tgstation deleted a comment from magatsuchi Jan 26, 2022
@tgstation tgstation deleted a comment from Coastfront Jan 26, 2022
@tgstation tgstation deleted a comment from Donpedrito Jan 26, 2022
@tgstation tgstation temporarily blocked MaineTheMan Jan 26, 2022
@tgstation tgstation deleted a comment from MaineTheMan Jan 26, 2022
@tgstation tgstation deleted a comment from MaineTheMan Jan 26, 2022
@tgstation tgstation temporarily blocked Coastfront Jan 26, 2022
@tgstation tgstation deleted a comment from Coastfront Jan 26, 2022
@tgstation tgstation deleted a comment from axietheaxolotl Jan 26, 2022
@tgstation tgstation unlocked this conversation Jan 26, 2022
@SomeDongus

This comment was marked as abuse.

@optimumtact
Copy link
Member

I'm going to smack your nuts one thousand nine hundred and eighty four times

@RaveRadbury
Copy link
Member

RaveRadbury commented Jan 27, 2022

As a sprite without any other context it looks great.

As an outfit that's meant to be a performer costume with sex appeal it doesn't work except for those who already know the reference.

The current outfit could pass as burlesque or something like it, the new outfit doesn't have any of the same implications in its form.

The new outfit does not easily communicate its purpose on-sight to an average player.

@VladinXXV
Copy link
Contributor

I'll admit the new sexy outfit is a pretty funny reference. However, I gotta agree with Rave here, without knowing the reference there's nothing really "sexy" about it. The overalls do look a little silly and characters like Mickey Mouse or Mario do somewhat come to mind. As far as I can tell from the IconDiff bot, the gloves and bandana aren't included anywhere in this, yet I don't think you're wearing everyday red gloves or a normal red bandana. Not sure what's going on there, maybe I'm just missing something.

As for the other sprites, I actually like what's been done with the Parcel Parceaux, the straps are much more out of the way now. (though contribute to a different issue I mention later) You mention something in your changelog about changing the mask, but I can't find any changes made to it. Was this in error?

The alt sprites haven't been touched, I feel like it'd be good to change those what little you can to match the new sprites, lest pulling your shirt down suddenly make your skirt solid black.

As for the bread and butter of the PR - the main uniform and the skirt... well, the new sprites aren't terrible, but I don't have it in me to denounce the originals. They look significantly worse in the provided image due to the new straps on the Parcel Parceaux making it look like the entire top shoulder area of the uniform is black. Looking at the uniform alone is preferrable.

@optimumtact
Copy link
Member

As a sprite without any other context it looks great.

As an outfit that's meant to be a performer costume with sex appeal it doesn't work except for those who already know the reference.

Dude on what planet are you living on, there is absolutely no basis for having that costume other than as a meme, so replacing it with a seperate meme is completely valid so again, all that matters is what sprite looks better.

Do you have some kind of personal attachement to the other sprite?

Copy link
Contributor

@Twaticus Twaticus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good waiting on alt sprites

@RaveRadbury
Copy link
Member

RaveRadbury commented Jan 27, 2022

As a sprite without any other context it looks great.

As an outfit that's meant to be a performer costume with sex appeal it doesn't work except for those who already know the reference.

Dude on what planet are you living on, there is absolutely no basis for having that costume other than as a meme, so replacing it with a seperate meme is completely valid so again, all that matters is what sprite looks better.

Do you have some kind of personal attachement to the other sprite?

No I just really don't like the new one.

The meme of the old one is akin to Halloween costumes being like "sexy nurse" etc, right?

This new one isn't like that, and it's not even a meme. It's just a reference, and not a common one.

Edit: I'd rather see the "sexy mime" costume gone completely rather than replaced with this.

@cacogen
Copy link
Contributor

cacogen commented Jan 27, 2022

i like these (:

@Kurgis
Copy link
Contributor

Kurgis commented Jan 27, 2022

The current outfit could pass as burlesque or something like it, -

Passes off as Cruella Deville.

@JinGiant
Copy link
Contributor

JinGiant commented Apr 3, 2022

False advertising, red gloves and pulled down bandanas do NOT exist

@necromanceranne
Copy link
Contributor

False advertising, red gloves and pulled down bandanas do NOT exist

Alt click the bandanna to make it into a neckerchief. Red gloves can be made by dying your white gloves in a washing machine along with a red crayon.

@JinGiant
Copy link
Contributor

JinGiant commented Apr 3, 2022

Alt click the bandanna to make it into a neckerchief. Red gloves can be made by dying your white gloves in a washing machine along with a red crayon.

I didn't know you could alt click them. I was taking the rgb value of the gloves in photoshop and spray painting them too, thank you very much. Now I can finally be a proper mime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Improvement Code is now easier to copy paste. Sprites A bikeshed full of soulless bikes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet