Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Janitorial Drip #24141

Merged
merged 5 commits into from
Feb 27, 2024
Merged

Janitorial Drip #24141

merged 5 commits into from
Feb 27, 2024

Conversation

Christasmurf
Copy link
Contributor

What Does This PR Do

Ports the galosh sprites from tg tgstation/tgstation#73688
Resprites the default janitor uniform
Adds jumpskirt and overalls variants
Adds beret, grey and purple caps for janitor
Adds janitorial gloves - Rubber, but not insulated. Protects the hands from burning on lightbulbs.

All items available in janidrobe, gloves and galoshes cost nothing.
Beret, caps and skirt available in loadout.
Jumpsuit and skirt can be rolled down, caps can be flipped or put on a corgi to make them look professional (get to work, slacker)

Why It's Good For The Game

Better looking clothing, more variation in style

Images of changes

Before:
image

After:
image

Testing

Spawn in, walk to janitor office, buy all the items from the vendor and try them on
Spawn magic mirror, test all items on different species

Changelog

馃啈
add: Added janitorial jumpskirt, overalls, beret, grey/purple caps, gloves.
imageadd: Resprited the default janitor jumpsuit and ported galosh sprites from tg
/:cl:

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally Sprites This PR modifies the game sprites labels Feb 10, 2024
@datlo
Copy link
Contributor

datlo commented Feb 10, 2024

Perhaps consider partial insulation on the rubber gloves?
Good changes tho 馃憤

@Christasmurf
Copy link
Contributor Author

Perhaps consider partial insulation on the rubber gloves? Good changes tho 馃憤

That was the original plan but I spoke with the balance team back when I first coded the item and they said no insulation just the heat protection that the black gloves get

@Henri215 Henri215 added the Requires Wiki Update Useful for Wiki Contributers to search for things that need updating label Feb 10, 2024
@Carthusia
Copy link

Are these just humanoid sprites or will other species versions need to be created for them?

@Henri215
Copy link
Member

Are these just humanoid sprites or will other species versions need to be created for them?

There are species versions.

@Christasmurf
Copy link
Contributor Author

Are these just humanoid sprites or will other species versions need to be created for them?

All species version are included I just don't put them in the screenshots

Copy link
Member

@Henri215 Henri215 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

image

Human overalls not 100% symmetrical because of that one pixel at the edge.
Everything else looks good.

@Christasmurf
Copy link
Contributor Author

image

image

Human overalls not 100% symmetrical because of that one pixel at the edge. Everything else looks good.

balls ass

Copy link
Member

@Henri215 Henri215 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LHTM (Looks Honkable To Me)

@SteelSlayer SteelSlayer added Feature This PR is a new addition to the game Port This PR is from another server, or heavily inspired/adapted. labels Feb 19, 2024
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting approval This PR is waiting for approval internally and removed -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally labels Feb 19, 2024
@github-actions github-actions bot added the Merge Conflict This PR is merge conflicted label Feb 19, 2024
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally -Status: Awaiting approval This PR is waiting for approval internally -Status: Awaiting merge This PR is ready for merge and removed -Status: Awaiting approval This PR is waiting for approval internally -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally labels Feb 22, 2024
@github-actions github-actions bot removed the Merge Conflict This PR is merge conflicted label Feb 25, 2024
Copy link
Contributor

@lewcc lewcc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (Let's Get This Mopped)

@lewcc lewcc merged commit 7dd4ecf into ParadiseSS13:master Feb 27, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-Status: Awaiting merge This PR is ready for merge Feature This PR is a new addition to the game Port This PR is from another server, or heavily inspired/adapted. Requires Wiki Update Useful for Wiki Contributers to search for things that need updating Sprites This PR modifies the game sprites
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants