-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Janitorial Drip #24141
Janitorial Drip #24141
Conversation
Perhaps consider partial insulation on the rubber gloves? |
That was the original plan but I spoke with the balance team back when I first coded the item and they said no insulation just the heat protection that the black gloves get |
Are these just humanoid sprites or will other species versions need to be created for them? |
There are species versions. |
All species version are included I just don't put them in the screenshots |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LHTM (Looks Honkable To Me)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (Let's Get This Mopped)
What Does This PR Do
Ports the galosh sprites from tg tgstation/tgstation#73688
Resprites the default janitor uniform
Adds jumpskirt and overalls variants
Adds beret, grey and purple caps for janitor
Adds janitorial gloves - Rubber, but not insulated. Protects the hands from burning on lightbulbs.
All items available in janidrobe, gloves and galoshes cost nothing.
Beret, caps and skirt available in loadout.
Jumpsuit and skirt can be rolled down, caps can be flipped or put on a corgi to make them look professional (get to work, slacker)
Why It's Good For The Game
Better looking clothing, more variation in style
Images of changes
Before:
![image](https://private-user-images.githubusercontent.com/25437893/303827880-b49694ab-a120-44c5-bcb0-9ac20bb43416.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTg3NTMwNjUsIm5iZiI6MTcxODc1Mjc2NSwicGF0aCI6Ii8yNTQzNzg5My8zMDM4Mjc4ODAtYjQ5Njk0YWItYTEyMC00NGM1LWJjYjAtOWFjMjBiYjQzNDE2LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MTglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjE4VDIzMTkyNVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWUxMmZjZjdhOTQzNDg3MDQxMWIwYzA4NjQ0ZTY5MDc4NTJkNjVhM2RlNzZlNjM4NDYyNmIxNTgzMWE5ZjVlNWMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.tifvOaKJHqpPlWgtTy84qcjJe9Wki-8lzr2sTTcOlxI)
After:
![image](https://private-user-images.githubusercontent.com/25437893/303827885-26f202e6-9529-4b06-88b5-3042b4619ecb.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTg3NTMwNjUsIm5iZiI6MTcxODc1Mjc2NSwicGF0aCI6Ii8yNTQzNzg5My8zMDM4Mjc4ODUtMjZmMjAyZTYtOTUyOS00YjA2LTg4YjUtMzA0MmI0NjE5ZWNiLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MTglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjE4VDIzMTkyNVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWIyNzVjNGYzN2UxZGIzZDY1MGZlMTMyNThmZDRiMGQ1NWVmYzljMDRjMGE1ZTE5MzBmYjcyYTgzY2M5YzNmMjcmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.VS0ym_Aixi6MueH7mL7N4AFfZk-cs8dZVoBJB-FUKWk)
Testing
Spawn in, walk to janitor office, buy all the items from the vendor and try them on
Spawn magic mirror, test all items on different species
Changelog
馃啈
add: Added janitorial jumpskirt, overalls, beret, grey/purple caps, gloves.
imageadd: Resprited the default janitor jumpsuit and ported galosh sprites from tg
/:cl: