Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

stylistic alterations of galoshes icons #73688

Merged
merged 4 commits into from Mar 4, 2023
Merged

stylistic alterations of galoshes icons #73688

merged 4 commits into from Mar 4, 2023

Conversation

Chlorotrifluoride
Copy link
Contributor

@Chlorotrifluoride Chlorotrifluoride commented Feb 27, 2023

About The Pull Request

updates the galoshes icons to make them stylistically similar to the work boots and jackboots, with the palate of the insulated gloves. also similarly modified the absorbent galoshes, but used color palate of the purple hat.
this includes the item's inventory icon, the worn icon and the in hand icons.

Why It's Good For The Game

it is much more aesthetically pleasing than the flat shaded, neon curry colored ones. also, it makes me feel pretty when I wear them with insulated gloves on.
image

Changelog

馃啈

imageadd: added prettier icons for the normal and absorbent galoshes

/:cl:

updated the galoshes sprite to make them more stylistically similar to the work boots and jackboots.
made the galoshes more stylistically similar to the jackboots and workboots.
updated the in-hand galoshes sprites to match their new color pallet
@tgstation-server tgstation-server added the Sprites A bikeshed full of soulless bikes. label Feb 27, 2023
@Sealed101
Copy link
Member

what's up with the other two sprite changes
image

@Chlorotrifluoride
Copy link
Contributor Author

Chlorotrifluoride commented Feb 27, 2023

what's up with the other two sprite changes image

I honestly have no clue, I wasn't even aware they where altered.

remove the two changed icons that weren't galoshes
@Chlorotrifluoride
Copy link
Contributor Author

Chlorotrifluoride commented Feb 28, 2023

alright, I removed the two other changes. I must have copied them from the wrong repository. woops.
thanks for pointing that out. how did you get that comparative view?

@VladinXXV
Copy link
Contributor

how did you get that comparative view?

https://github.com/tgstation/tgstation/pull/73688/checks?check_run_id=11642670155

Include absorbent galoshes picture in PR body please? Long overdue, good PR.

@Chlorotrifluoride
Copy link
Contributor Author

Include absorbent galoshes picture in PR body please? Long overdue, good PR.

ah, good point. and thanks!
I want to clean up a bunch of the older looking sprites (especially the mundane ones) to bring them up to par with some of the newer ones. this PR is hopefully just the start.

Copy link
Contributor

@Imaginos16 Imaginos16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect!

@JohnFulpWillard JohnFulpWillard merged commit d0474ed into tgstation:master Mar 4, 2023
github-actions bot added a commit that referenced this pull request Mar 4, 2023
comfyorange added a commit that referenced this pull request Mar 4, 2023
Jolly-66 pushed a commit to TaleStation/TaleStation that referenced this pull request Mar 4, 2023
Original PR: tgstation/tgstation#73688
-----
## About The Pull Request
updates the galoshes icons to make them stylistically similar to the
work boots and jackboots, with the palate of the insulated gloves. also
similarly modified the absorbent galoshes, but used color palate of the
purple hat.
this includes the item's inventory icon, the worn icon and the in hand
icons.

## Why It's Good For The Game

it is much more aesthetically pleasing than the flat shaded, neon curry
colored ones. also, it makes me feel pretty when I wear them with
insulated gloves on.

![image](https://user-images.githubusercontent.com/121331795/221738653-86ebc317-cf59-4524-ba8a-dcdf8528710e.png)



## Changelog

:cl:

imageadd: added prettier icons for the normal and absorbent galoshes

/:cl:

---------

Co-authored-by: Chlorotrifluoride <121331795+Chlorotrifluoride@users.noreply.github.com>
scriptis pushed a commit to scriptis/tgstation that referenced this pull request Apr 1, 2023
updates the galoshes icons to make them stylistically similar to the
work boots and jackboots, with the palate of the insulated gloves. also
similarly modified the absorbent galoshes, but used color palate of the
purple hat.
this includes the item's inventory icon, the worn icon and the in hand
icons.

it is much more aesthetically pleasing than the flat shaded, neon curry
colored ones. also, it makes me feel pretty when I wear them with
insulated gloves on.
scriptis pushed a commit to scriptis/tgstation that referenced this pull request Apr 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Sprites A bikeshed full of soulless bikes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants