Removes the drone ghost role, replaces it with a MODsuit Module

[DGamerL]

What Does This PR Do

• Removes the drone ghost role
• Removes the drone control console
• Adds a new MODsuit module: the "MOD Personal Artificial Intelligence Storage" (Name is a WIP)

Replaces the drone lawset:

	1. You may not cause direct harm to another being.
	2. You may not vandalize or cause damage to the station.
	3. Obey any orders given to you by your master, except when they violate the previous laws.
	4. You must repair any damage to the station to the best of your abilities.

This module can:

• Poll ghosts to have one of them inhabit a drone that will be linked to the Module. Costs power, you can only have one drone per mod, and only one mod per MODsuit
• You can use a pAI on the MODsuit to change that pAI into a drone, does not cost power

TODO:

• Add power usage on drone creation
• Make it only take power if summoned out of thin air
• Make sure you can't spam drones by removing and adding new MODs every time.
• Add the ability for drones to enter a MODsuit (Action button?)
• Give drones new laws
• Clean code up
• Decide on what to do with shutting down drones with IDs/PDAs
• Decides if we will allow to have drones switch back to pAIs
• Probably more stuff that I forgot

Test to see if it still works:

• Drones returning if inactive

Drones now get 2 new action buttons:

• Return to MODsuit. This ability allows them to move inside their linked MODsuit if they are close enough, and if not, they'll automatically pathfind towards it!
• Drop out of MODsuit. This one just drops them on the turf of the MODsuit they are in. Does nothing if used outside of a MODsuit.

Why It's Good For The Game

Alternative to #24166 . This PR aims to keep the drone/dchat supporting role, if an engineer/random person wants to have drones help out.
These drones will end up as a pAI sidegrade, being able to interact with people. They will also get laws to discourage them to fight against biohazards
I think this would be a more fun alternative

Images of changes

[Insert image here]

Testing

I had an image but it got lost on my clipboard

Changelog

🆑
experiment: Someone merged a draft PR
/:cl:

[TravisAngeI]

definitely like this alternative compared to outright removal

so if im reading this right the intent is to make it to where you can effectively just summon a differently lawwed maintenance drone at the cost of power?

[DGamerL]

definitely like this alternative compared to outright removal

so if im reading this right the intent is to make it to where you can effectively just summon a differently lawwed maintenance drone at the cost of power?

Most likely, yes
The fine details are still up in the air, but that is the general outline.
You can also put a pAI in and they will automatically be changed into a drone, but they do lose all other pAI tools

[EmeraldCandy]

definitely like this alternative compared to outright removal
so if im reading this right the intent is to make it to where you can effectively just summon a differently lawwed maintenance drone at the cost of power?

Most likely, yes The fine details are still up in the air, but that is the general outline. You can also put a pAI in and they will automatically be changed into a drone, but they do lose all other pAI tools

I feel its dangerous to give people a free maint drone from a PAI that they can control, as that player will very much be inclined to help their summoner. Even if lawed to not do things such as not harm people and dont break things, etc, this still poses a big challenge. For the cost of a modsuit module slot, you can effectively have AA from dragging along a drone, tools, and potentially even a way to attack/interact with objects/others nearby if you're incapacitated or otherwise busy. For antags this is obviously a very powerful tool. Especially an IPC user who basically has a pocket medic at their disposal. I am under the belief that this maint drone summoned out should still be very "mindless" like the current ones are, and if you can inset a PAI into it, it should be HEAVILY restricted and lawed on what it is/isnt allowed to do while in drone form.

[LiberatedWaveMan]

i disagree with the changeover, but that doesn't matter too much- what i will say, however, is that i think it'd be a net negative to lose out on the "chill and don't have to communicate" thing by making it an interactive, pAI thing only

[Contrabang]

We should probably check if they're already pathfinding before asking the user, so that people cant generate 1000 pathfinding requests

[FunnyMan3595]

experiment: Someone merged a draft PR

... but it's not marked as a draft?

[DGamerL]

experiment: Someone merged a draft PR

... but it's not marked as a draft?

Yeah, but it's also not really finished at the same time

[Ionward]

i'm curious to know how you'd deal with the language stuff with drones, maybe they all communicate like normal but can also speak to whoever's wearing the master-modsuit? that way they're not just a straight up PAI upgrade but are limited to only relaying info to their master, or coordinating with other silicons

[FunnyMan3595]

Might want to take a look at removing the resources here if drones just take power to make:

Paradise/code/modules/mob/living/silicon/robot/drone/maint_drone.dm

Lines 407 to 409 in a50dc50

	C.stored_comms["metal"] += 15
	C.stored_comms["glass"] += 15
	C.stored_comms["wood"] += 5

[FunnyMan3595]

Might want to think about whether we still want drones to be able to take ghost role spawns, especially ones that used to be a pAI.

[github-actions]

This pull request seems to be stale as there have been no changes in 14 days, please make changes within 7 days or the PR will be closed. If you believe this is a mistake, please inform a development team member on Discord.

[github-actions]

This pull request seems to be stale as there have been no changes in 14 days, please make changes within 7 days or the PR will be closed. If you believe this is a mistake, please inform a development team member on Discord.

[github-actions]

This pull request has not received any updates since being marked stale, and as such is now being automatically closed. Please feel free to re-open this pull request or open a new one once you have new updates.