Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drones are now cargo-purchaseable, makes the console public #25572

Closed
wants to merge 7 commits into from

Conversation

Contrabang
Copy link
Contributor

@Contrabang Contrabang commented May 22, 2024

What Does This PR Do

I've thrown around a lot of ideas for maint drones as an alternative to #24207. I think this is the best one.

  • Drones are no longer infinitely spawnable from the drone fab
  • Drone fabs are now "drone storages"
  • Drones are ordered from cargo for 400 credits for 3 of them
  • Drones no longer gib on death
  • Emagged drones now gib at the end of their timer instead of just shutting down
  • Anyone with Maintenance access can shut down a maint drone by swiping their ID in it (as long as its not emagged)
  • Drone storage now displays number of active drones (players) and stored drones (clientless drones that players can join as)
  • Drone storages can now be found in maintenance instead of engineering. They really are MAINTENANCE drones.
  • Drones no longer have a max-cap of 5 per fabricator.

Why It's Good For The Game

This PR aims to keep the drone/dchat supporting role, but in a way that requires player agency.

Images of changes

image
image
image

Testing

Ordered some drones, tested shit with em

Changelog

🆑
tweak: Drones are now cargo-orderable instead of being in infinite supply from the drone fabricator
/:cl:

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally Map Edit This PR will modify a map TGUI This PR modifies TGUI, will conflict labels May 22, 2024
@Daylight2
Copy link
Contributor

Since they're now in limited supply, I feel like drones should pathfind back to the fab and become available to other players if you ghost out of them. Also some tweak to either their capability or lawset might be warranted, since they're no longer free and won't show up every shift.

Copy link
Contributor

@1080pCat 1080pCat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe you've reverted funnymans request console update pr.

Also could you move the drone fab on meta down to around here?
image
where it is now looks.. outa place

@SteelSlayer SteelSlayer added the Tweak This PR tweaks something ingame label May 22, 2024
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting approval This PR is waiting for approval internally and removed -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally labels May 22, 2024
@github-actions github-actions bot added the Merge Conflict This PR is merge conflicted label May 22, 2024
@github-actions github-actions bot removed the Merge Conflict This PR is merge conflicted label May 23, 2024
@FunnyMan3595
Copy link
Contributor

Neat idea, but it doesn't solve the admin work or bad lawset issues that plague drones.

@Contrabang
Copy link
Contributor Author

Neat idea, but it doesn't solve the admin work or bad lawset issues that plague drones.

I think that limiting the supply of them is something that is needed for the lawset to be reworked. As for the admin issues, I do not have enough experience admining to say anything on that, nor where to go with that.

@1080pCat
Copy link
Contributor

I've got.. Quite a strong opinion against this, i've been thinking about it for a while.

I do not believe this would solve anything. Making the drones cost 400 credits for 3 drones, is just, weird.
I expect this to result in the dronefab being neglected, and just never stocked.

The primary issue with drones is their horrid laws, that contradict themselves, and are super vague. Not that they're easily accessible.
Moving the drones fabs to maintenance is.. interesting, im not super apposed to it, but im concerned about tiders seeing the shutdown button and just shutting down drones for the hell of it.

Also with how.. short the "why its good for the game" is, it seems like even you dont have super solid reasoning for it, somewhat feels like a change to change it. No offense.

TLDR: The drones need new laws, not mechanical changes.

@github-actions github-actions bot added the Merge Conflict This PR is merge conflicted label May 27, 2024
@Contrabang
Copy link
Contributor Author

I've got.. Quite a strong opinion against this, i've been thinking about it for a while.

I do not believe this would solve anything. Making the drones cost 400 credits for 3 drones, is just, weird. I expect this to result in the dronefab being neglected, and just never stocked.

The primary issue with drones is their horrid laws, that contradict themselves, and are super vague. Not that they're easily accessible. Moving the drones fabs to maintenance is.. interesting, im not super apposed to it, but im concerned about tiders seeing the shutdown button and just shutting down drones for the hell of it.

Also with how.. short the "why its good for the game" is, it seems like even you dont have super solid reasoning for it, somewhat feels like a change to change it. No offense.

TLDR: The drones need new laws, not mechanical changes.

Fair, this idea started when the 2 PRs open for drones were

  1. Removing them from the game completely
  2. Making them into a pAI modsuit module
    I'm fine with this PR being closed if there are enough objections against it

@bruhlookatthisdood
Copy link

bruhlookatthisdood commented May 30, 2024

if this does go through, is there any chance the round can start with like, one drone or even two?
i don't want to be locked out of the role when cargo just completely forgets or refuses to buy them.

@Kenionatus
Copy link

I feel like the drone fab/storage being in engineering would be even more important with this PR, because then engineering would be clearly responsible for stocking it.

Copy link
Contributor

@Spaghetti-bit Spaghetti-bit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approve for code

data["selected_area"] = drone_call_area
data["ping_cd"] = ping_cooldown > world.time ? TRUE : FALSE

data["drones"] = list()
var/active_drones = 0
var/stored_drones = 0
var/total_drones = 0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know they're pretty obvious what they each do, but please autodoc these.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Theres no use for auto-doc comments in a proc, they won't be recognized. Normal comments are fine for situations like these, but I feel these are already self-documenting enough

@SteelSlayer
Copy link
Member

This PR has failed the Design team vote with 3 against and 0 in favor. Here are the objection reasons:

Member 1: Neat idea, but it doesn't solve the admin work or bad lawset issues that plague drones.
Member 2: Same thoughts as Member 1. Still does not solve the drone issue and them being how they exist currently on station with their laws, admin issues, and in general bad concept.
Member 3: Yeah, while it is nice that something is attempting to be done to help the drones along, this doesn't seem like it'll do a whole lot to fix the issues that people have with them.

@SteelSlayer SteelSlayer closed this Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-Status: Awaiting approval This PR is waiting for approval internally Map Edit This PR will modify a map Merge Conflict This PR is merge conflicted TGUI This PR modifies TGUI, will conflict Tweak This PR tweaks something ingame
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants