Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable netcdf4 only if NetCDF 4.9.0 and later #134

Closed
wants to merge 8 commits into from
Closed

Conversation

wkliao
Copy link
Member

@wkliao wkliao commented Mar 26, 2022

NC_NODIMSCALE_ATTACH is first defined in NetCDF-C version 4.9.0.
This flag is required to run netcdf4 option. See
Unidata/netcdf-c#2251

* NetCDF-4 uses the dimension scale feature which is part of HDF5
  high-level APIs, but HDF5 high-level APIs are not well tested for
  parallel I/O. See Unidata/netcdf-c#2251 and
  Unidata/netcdf-c#1822
* NetCDF PR #2161 adds a new flag NC_NODIMSCALE_ATTACH to allow users to
  disable dimension scale, which resolves the problem for e3sm-io. See
  Unidata/netcdf-c#2161
* NetCDF team indicates PR #2161 will appear in version 4.9.0.
@wkliao
Copy link
Member Author

wkliao commented Apr 22, 2022

Instead of requiring NetCDF 4.9.0, a better approach is to check if NC_NODIMSCALE_ATTACH is defined.

Close this PR in preference to #136

@wkliao wkliao closed this Apr 22, 2022
@wkliao wkliao deleted the netcdf-4.9.0 branch July 10, 2022 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant