Javascript optimizations #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
functions which are called on an interval or repeatedly. -Bind template data to a variable to avoid 'with' usage. -Build up markup in a string instead of adding within a loop to avoid repaints. -Bind event listeners to table containers instead of each element.
|
Also fixing the json routes which were broken with the conversion to absolute urls. |
|
Seems legit, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are a couple of front-end optimizations to the Javascript that we've been using to make the dashboard usable with thousands of jobs. While not as necessary with the recent introduction of pagination, they still make the page perceptively faster.