Add Piecewise FastSRM #50
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
@thomasbazeille would you mind taking a look at that ? Let me know if you can't. |
|
Sorry for the (huge) delay, I'll check it ASAP |
|
🙋 I'm happy to pick this up ! @hugorichard I assume you don't have time to fix the merge conflicts here ; I'll plan to open a superseding PR with these changes unless I hear otherwise from you. Thanks ! |
|
Hello Elizabeth,
Indeed, I won't have time to merge conflicts.
Fill free to do as you wish :)
Thanks a lot for taking care of this.
Le mar. 5 sept. 2023 à 22:17, Elizabeth DuPre ***@***.***> a
écrit :
… 🙋 I'm happy to pick this up ! @hugorichard
<https://github.com/hugorichard> I assume you don't have time to fix the
merge conflicts here ; I'll plan to open a superseding PR with these
changes unless I hear otherwise from you. Thanks !
—
Reply to this email directly, view it on GitHub
<#50 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACK4DFTHSGAOZUEIIBF3EQTXY6CERANCNFSM5I7KGIYA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
emdupre
force-pushed
the
main
branch
2 times, most recently
from
cc75363
to
0e1ce05
Compare
|
Closing now that #70 has been merged. Thank you, @hugorichard ! |
|
Thx to all ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a copy of the piecewise SRM package of Thomas.
It uses the last version of FastSRM. This is relevant for #49