Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impact of the new unique indexes on the _User table for parse-server 2.3.0+ #3324

Closed
asdf01 opened this issue Jan 5, 2017 · 2 comments
Closed

Comments

@asdf01
Copy link

asdf01 commented Jan 5, 2017

Hello parse-server elders

Thanks for looking into this issue.

I upgraded to 2.3.0, then to 2.3.1 and noticed this 2.3.0 guide. I thought I had to get those unique indexes created otherwise my parse-server wouldn't work.

I can see that the parse-server code does try to create those unique indexes on startup. On some of my database, it seems to be able to do it where the data allows it, on some it quietly fails without any mention in the logs. Is that the expected behaviour?

I can see the error handlers in MongoStorageAdapter and DatabaseController but they don't seem to be called when the existing data is not unique.

My main question for you guys is whether I actually need to do anything when upgrading to 2.3.0+. From the wording in the upgrade guide it sounds like the javascript code based uniqueness check has been or will be removed and replaced with an index based uniqueness check.

However looking at the code, it looks like the javascript based username and email checks are still there.

I don't mean to be difficult and go against the advice of creating these indexes, but it seems to be an impossible task for us to analyse and fix all the username and email issues that we have across our numerous databases. So I would like to avoid it if it's not going to cause us any issues.

Does this index based approach mean that you guys are going to be removing the javascript based check some time in the future? Do you guys know of any issues with using 2.3.0+ without those indexes?

Thanks

@alexblack
Copy link

+1

@hramos
Copy link
Contributor

hramos commented Feb 10, 2017

Hey, thanks for reporting this issue.

Can you please add all the info specified in the template? This is necessary for people to be able to understand and reproduce the issue being reported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants