🐛Fixes ima-video race condition and percentage played (ampproject#24900)

Fixes the race condition that causes the ima-video player to freeze with slow network connection. Also added event trigger to calculate percentage played. Closes ampproject#23356
Parsely · Oct 22, 2019 · a2cc90d · a2cc90d
1 parent e168e1e
commit a2cc90d
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/extensions/amp-ima-video/0.1/amp-ima-video.js b/extensions/amp-ima-video/0.1/amp-ima-video.js
@@ -286,6 +286,7 @@ class AmpImaVideo extends AMP.BaseElement {
     }
     if (videoEvent == ImaPlayerData.IMA_PLAYER_DATA) {
       this.playerData_ = /** @type {!ImaPlayerData} */ (eventData['data']);
+      this.element.dispatchCustomEvent(VideoEvents.LOADEDMETADATA);
       return;
     }
     if (videoEvent == 'fullscreenchange') {

diff --git a/src/service/video-manager-impl.js b/src/service/video-manager-impl.js
@@ -1433,8 +1433,9 @@ export class AnalyticsPercentageTracker {
     const {video} = this.entry_;
     const duration = video.getDuration();
 
-    // Livestreams or videos with no duration information available.
-    if (!duration || isNaN(duration) || duration <= 0) {
+    // Livestreams or videos with no duration information available,
+    // where 1 second is the default duration for some video players
+    if (!duration || isNaN(duration) || duration <= 1) {
       return false;
     }