Skip to content
This repository has been archived by the owner on Mar 24, 2021. It is now read-only.

Support standard partition assignment strategies #657

Closed
emmettbutler opened this issue Feb 22, 2017 · 1 comment
Closed

Support standard partition assignment strategies #657

emmettbutler opened this issue Feb 22, 2017 · 1 comment

Comments

@emmettbutler
Copy link
Contributor

#655 points out pykafka's lack of support for the standard roundrobin and range partition assignment strategies, described here. Support for these strategies is required for interoperability with other kafka clients. The strategy should be selectable by a kwarg on BalancedConsumer that will accept a string roundrobin|range and will effectively swap between different implementations of _decide_partitions.

@jeffwidman
Copy link
Contributor

jeffwidman commented Mar 7, 2017

Are you sure you want the kwarg to be a string? There are more partition strategies coming down the pipe, for example KIP-54 is slated for Kafka 0.11.0. Plus a user may wish to implement a custom one. So you might want to make the kwarg be a subclass of a basic partitioning class, with the two shipped by default being RoundRobin and Range

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants