Skip to content
This repository has been archived by the owner on Mar 24, 2021. It is now read-only.

Allow support for ListOffset API version 1. #997

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions pykafka/protocol/offset.py
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ class ListOffsetRequest(Request):
@classmethod
def get_versions(cls):
# XXX use ListOffsetRequestV1 after 0.10 message format is supported
return {0: ListOffsetRequest, 1: ListOffsetRequest}
return {0: ListOffsetRequest, 1: ListOffsetRequestV1}

def __init__(self, partition_requests):
"""Create a new offset request"""
Expand Down Expand Up @@ -160,7 +160,7 @@ class ListOffsetResponse(Response):
@classmethod
def get_versions(cls):
# XXX use ListOffsetResponseV1 after 0.10 message format is supported
return {0: ListOffsetResponse, 1: ListOffsetResponse}
return {0: ListOffsetResponse, 1: ListOffsetResponseV1}

def __init__(self, buff):
"""Deserialize into a new Response
Expand Down Expand Up @@ -195,7 +195,7 @@ def __init__(self, buff):
:param buff: Serialized message
:type buff: :class:`bytearray`
"""
fmt = '[S [ihq [q] ] ]'
fmt = '[S [ihqq] ]'
response = struct_helpers.unpack_from(fmt, buff, 0)

self.topics = {}
Expand Down