Skip to content

Commit

Permalink
Remove vestigial monitoring parameter (#3411)
Browse files Browse the repository at this point in the history
The use of this parameter was removed in PR #3346
  • Loading branch information
benclifford committed May 3, 2024
1 parent 4a4192b commit b2ea99a
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 6 deletions.
4 changes: 1 addition & 3 deletions parsl/dataflow/dflow.py
Original file line number Diff line number Diff line change
Expand Up @@ -177,11 +177,9 @@ def __init__(self, config: Config) -> None:

# this must be set before executors are added since add_executors calls
# job_status_poller.add_executors.
radio = self.monitoring.radio if self.monitoring else None
self.job_status_poller = JobStatusPoller(strategy=self.config.strategy,
strategy_period=self.config.strategy_period,
max_idletime=self.config.max_idletime,
monitoring=radio)
max_idletime=self.config.max_idletime)

self.executors: Dict[str, ParslExecutor] = {}

Expand Down
4 changes: 1 addition & 3 deletions parsl/jobs/job_status_poller.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import logging
import parsl
from typing import List, Sequence, Optional, Union

from parsl.jobs.strategy import Strategy
Expand All @@ -14,8 +13,7 @@

class JobStatusPoller(Timer):
def __init__(self, *, strategy: Optional[str], max_idletime: float,
strategy_period: Union[float, int],
monitoring: Optional["parsl.monitoring.radios.MonitoringRadio"] = None) -> None:
strategy_period: Union[float, int]) -> None:
self._executors = [] # type: List[BlockProviderExecutor]
self._strategy = Strategy(strategy=strategy,
max_idletime=max_idletime)
Expand Down

0 comments on commit b2ea99a

Please sign in to comment.