Skip to content

Commit

Permalink
fix: launch_cmd not set when provided to FluxExecutor
Browse files Browse the repository at this point in the history
Problem: Currently, the launch_cmd is not set if provided to the
FluxExecutor directly. Many jobs are likely to start
already with access to a flux instance, in which case
the launch command should use flux submit instead of
flux start.
Solution: Ensure the launch_cmd is set.

Signed-off-by: vsoch <vsoch@users.noreply.github.com>
  • Loading branch information
vsoch committed Mar 17, 2023
1 parent 33398b1 commit c8d418c
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions parsl/executors/flux/executor.py
Original file line number Diff line number Diff line change
Expand Up @@ -201,8 +201,8 @@ def __init__(
self.flux_path = os.path.abspath(flux_path)
self._task_id_counter = itertools.count()
self._socket = zmq.Context().socket(zmq.REP)
if launch_cmd is None:
self.launch_cmd = self.DEFAULT_LAUNCH_CMD
# Assumes a launch command cannot be None or empty
self.launch_cmd = launch_cmd or self.DEFAULT_LAUNCH_CMD
self._submission_queue: queue.Queue = queue.Queue()
self._stop_event = threading.Event()
# lock to protect self._task_id_counter and also submission/shutdown race
Expand Down

0 comments on commit c8d418c

Please sign in to comment.