Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hide dfk #50

Closed
danielskatz opened this Issue Dec 12, 2017 · 0 comments

Comments

Projects
None yet
3 participants
@danielskatz
Copy link
Collaborator

danielskatz commented Dec 12, 2017

If 99% of users and usages don't use the dfk variable, but simply pass it in and out of various functions, we should hide it by default.

Can we do this in a backward compatible way? (make dkf an optional arg)

This probably requires major documentation/tutorial changes.

@annawoodard annawoodard assigned annawoodard and unassigned yadudoc Apr 23, 2018

@annawoodard annawoodard added this to the Parsl-0.6.0 milestone Apr 23, 2018

annawoodard added a commit that referenced this issue May 1, 2018

Add a singleton class for loading the DFK
This allows users to load either a DFK object or a file containing
a configuration dictionary. Unfortunately currently this relies on the
dictionary being called `config`. Once class-based configs are
implemented, we can improve this by loading any `Config` class objects
in the file. After a DFK has been loaded, Apps can be imported
without specifying an executor. If an app does not specify an executor
and a DFK has not been loaded, a `RuntimeError` will be raised.
Fixes #50.

annawoodard added a commit that referenced this issue May 1, 2018

Add a singleton class for loading the DFK
This allows users to load either a DFK object or a file containing
a configuration dictionary. Unfortunately currently this relies on the
dictionary being called `config`. Once class-based configs are
implemented, we can improve this by loading any `Config` class objects
in the file. After a DFK has been loaded, Apps can be imported
without specifying an executor. If an app does not specify an executor
and a DFK has not been loaded, a `RuntimeError` will be raised.
Fixes #50.

annawoodard added a commit that referenced this issue May 4, 2018

Add a singleton class for loading the DFK
This allows users to load a configuration which will be used to
instantiate a DFK, which is set as the active DFK. After a DFK has been
loaded, Apps can be imported without specifying an executor. If an app
does not specify an executor and a DFK has not been loaded, a
`RuntimeError` will be raised. Fixes #50.

annawoodard added a commit that referenced this issue May 4, 2018

Add a singleton class for loading the DFK
This allows users to load a configuration which will be used to
instantiate a DFK, which is set as the active DFK. After a DFK has been
loaded, Apps can be imported without specifying an executor. If an app
does not specify an executor and a DFK has not been loaded, a
`RuntimeError` will be raised. Fixes #50.

annawoodard added a commit that referenced this issue May 4, 2018

Add a singleton class for loading the DFK
This allows users to load a configuration which will be used to
instantiate a DFK, which is set as the active DFK. After a DFK has been
loaded, Apps can be imported without specifying an executor. If an app
does not specify an executor and a DFK has not been loaded, a
`RuntimeError` will be raised. Fixes #50.

@yadudoc yadudoc closed this in da59352 May 6, 2018

yadudoc added a commit that referenced this issue May 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.