hide dfk #50
Comments
annawoodard
added a commit
that referenced
this issue
May 1, 2018
This allows users to load either a DFK object or a file containing a configuration dictionary. Unfortunately currently this relies on the dictionary being called `config`. Once class-based configs are implemented, we can improve this by loading any `Config` class objects in the file. After a DFK has been loaded, Apps can be imported without specifying an executor. If an app does not specify an executor and a DFK has not been loaded, a `RuntimeError` will be raised. Fixes #50.
annawoodard
added a commit
that referenced
this issue
May 1, 2018
This allows users to load either a DFK object or a file containing a configuration dictionary. Unfortunately currently this relies on the dictionary being called `config`. Once class-based configs are implemented, we can improve this by loading any `Config` class objects in the file. After a DFK has been loaded, Apps can be imported without specifying an executor. If an app does not specify an executor and a DFK has not been loaded, a `RuntimeError` will be raised. Fixes #50.
annawoodard
added a commit
that referenced
this issue
May 4, 2018
This allows users to load a configuration which will be used to instantiate a DFK, which is set as the active DFK. After a DFK has been loaded, Apps can be imported without specifying an executor. If an app does not specify an executor and a DFK has not been loaded, a `RuntimeError` will be raised. Fixes #50.
annawoodard
added a commit
that referenced
this issue
May 4, 2018
This allows users to load a configuration which will be used to instantiate a DFK, which is set as the active DFK. After a DFK has been loaded, Apps can be imported without specifying an executor. If an app does not specify an executor and a DFK has not been loaded, a `RuntimeError` will be raised. Fixes #50.
annawoodard
added a commit
that referenced
this issue
May 4, 2018
This allows users to load a configuration which will be used to instantiate a DFK, which is set as the active DFK. After a DFK has been loaded, Apps can be imported without specifying an executor. If an app does not specify an executor and a DFK has not been loaded, a `RuntimeError` will be raised. Fixes #50.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
If 99% of users and usages don't use the dfk variable, but simply pass it in and out of various functions, we should hide it by default.
Can we do this in a backward compatible way? (make dkf an optional arg)
This probably requires major documentation/tutorial changes.
The text was updated successfully, but these errors were encountered: