Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unneeded task_id param from sanitize_and_wrap #2081

Merged
merged 2 commits into from
Jun 6, 2021
Merged

Remove unneeded task_id param from sanitize_and_wrap #2081

merged 2 commits into from
Jun 6, 2021

Conversation

benclifford
Copy link
Collaborator

See #2014

Type of change

  • Code maintentance/cleanup

@benclifford benclifford requested a review from yadudoc June 3, 2021 10:49
@benclifford benclifford added this to the 1.2 milestone Jun 3, 2021
yadudoc
yadudoc approved these changes Jun 4, 2021
View reviewed changes
Copy link
Member

@yadudoc yadudoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. I also see that the sanitize_and_wrap docs include a func option in args which is now obsolete.

@benclifford benclifford merged commit 3fd766c into master Jun 6, 2021
@benclifford benclifford deleted the benc-taskid-elim-sanitize branch June 6, 2021 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yadudoc yadudoc yadudoc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.2
Development

Successfully merging this pull request may close these issues.
2 participants
@benclifford @yadudoc