Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce max-length of flake8 #3201

Merged
merged 4 commits into from
Mar 7, 2024
Merged

Reduce max-length of flake8 #3201

merged 4 commits into from
Mar 7, 2024

Conversation

marameref
Copy link
Contributor

@marameref marameref commented Mar 7, 2024

Description

Please include a summary of the change and (optionally) which issue is fixed. Please also include
relevant motivation and context.

  • Reduce max-length of flake8 to 147 and made changes various files to conform to the new update successfully

Changed Behaviour

Which existing user workflows or functionality will behave differently after this PR?
none

Fixes

Fixes # (3105)

Type of change

Choose which options apply, and delete the ones which do not apply.

  • Code maintenance/cleanup

@benclifford I have revamped and corrected the work as requested, pls review

Copy link
Member

@yadudoc yadudoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @marameref, Nice job on this PR! It looks like the changes here are all good, but there are a few merge conflicts. Please take a look at this document to understand how to resolve these merge conflicts -> https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/addressing-merge-conflicts/resolving-a-merge-conflict-on-github

I appreciate your effort on this PR, so please let me know if you need help resolving the merge conflicts.

@marameref
Copy link
Contributor Author

hi, @yadudoc i believe i have been able to resolve the merge conflicts, the documentation was pretty helpful, thanks you for your aid, pls review and let me know my attention is still needed, if not ... pls merge

Copy link
Member

@yadudoc yadudoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like all the pending issues here have been resolved. Once the CI tests pass, this PR is good to merge to master. Once again, nice job @marameref!

@marameref
Copy link
Contributor Author

Thank you for the response @yadudoc , am happy to hear that, i am also happy to inform you that all the CI tests passed, I look forward to you merging my PR. Thanks once again

@yadudoc yadudoc merged commit 49cca8a into Parsl:master Mar 7, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants