-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Outreachy: getting familiar with the development environment #3105
Comments
My application got approved in outreachy, I will take this and create a pr |
@Harichandra-Prasath ok great! This specific issue #3105 isn't limited to one applicant: it's a basic exercise for everyone to get a development environment going, so other people reading this shoudn't be put off trying this out too. |
I am very interested in this project, sir. May I know how to get started and do quality contributions. |
@Harichandra-Prasath work your way through this issue #3105 and get a pull request merged from a working dev environment, to get started - when that is all working, we can pick out some other issues that are good for you to work on. |
@benclifford I am really interested in this project. I hope to learn and contribute to the project. |
Hello @benclifford ! Could you spend a few minutes of your precious time reviewing #3128 ?Thanks in advance! |
Hey @benclifford please review #3126 . Thank you :). |
Hello @benclifford please take a look! |
Hi @benclifford I am an outreachy applicant and I am interested in contributing to this project. Kindly review my PR #3130 Thank you. |
Hey @benclifford My initial application to outreachy got accepted and I'm interested to make contributions in this project. Looking forward to your feedback. Thanks! |
hi @benclifford, i just got accepted into the contribution phase of outreachy 2024, and i just created a PR on pls review and merge. Thanks |
Hey @benclifford |
Hi @benclifford please review my PR #3169 I also updated the readme. |
While setting up on macos, I encoutered similar issues @OfficialOzioma faced. When i ran When also running the Also, if you get and error flake8 not found when running |
@kemsguy7 ok, that sched_affinity message sounds like a cross-platform problem where we have tested things right on OS X - I'd be interested if you could paste the whole command and the whole output for that |
@kemsguy7 once you've done |
@SobiaAman asked elsewhere:
Its fine for as many people try the more simple issues as they want - but in the end, we will only merge one PR, the first PR that is properly ready with all mentor/reviewer comments addressed. So if you want to try an issue to learn about it, even if someone else is already working on it, you are welcome to try it and get mentor/reviewer feedback - but if you see someone else is doing it, it might be that their PR is what gets merged, not yours, depending on which PR is fully ready to be approved first. |
Okay, i'll do that |
Okay @benclifford |
@benclifford you still haven't reviewed my PR : #3176 |
Hello everyone, Let's address the errors to facilitate the creation of your pull request. why this issue occuring ?because you have not fetch the recent changes in your pc Important messageYou should always use a new branch for every different task How to fix it ?first then say the next step is to make a new branch by if you type the next step is to make change in your code and is you type then make commit by now type now push your changes by |
Hello @benclifford i've done this task of reducing flake8 max-line length in a separate branch and open an PR #3190 Kindly have a look |
Hello @benclifford |
we've closed outreachy applications for new applicants, so I'll close this issue - but existing applicants, if you have interesting information about completing this process, please add comments. |
Hi @benclifford I have made changes to the PR as requested. Can you pls review my PR: #3201 thanks in advance |
Thank you for the nugget @benclifford |
This issue is targeted at potential applications for Parsl's participation in Outreachy. The tasks in this issue can be performed by any number of applicants. Talk to @benclifford on Slack if you are interested.
The point of the tasks in this issue are to walk you through getting a development environment set up, making a trivial change to the code, seeing how our tooling tests things, deliberately introducing a problem, and then fixing that problem. By the end you should have a trivial 1-byte change to submit to parsl as a PR, to try out the PR process.
There are lots of steps because I have tried to make each step small.
If you get stuck or don't understand any of these steps - you can ask @benclifford on Slack or write publicly in the #parsl-hackers channel on Slack.
git clone https://github.com/parsl/parsl
, instead use the address of your fork created in the previous step.make local_thread_test
, and some more advanced tests withmake htex_local_alternate_test
.flake8
. You can open that file and make a change to move us towards proper PEP-8 compliance: find the line that saysmax-line-length = 158
and make it 1 smaller. (PEP-8 says the max line length should be 80... but we can't change it all at once)make flake8
again - you should see that you can an error: flake8 should have found a line that is now too long.make flake8
again and you should see that flake8 passes againgit commit -a -m "Reduce flake8 max-line-length
. Don't worry if you don't understand what git is doing: you can learn more about that during the internship.git push
The text was updated successfully, but these errors were encountered: